Code cleanup

This commit is contained in:
DarthAffe committed 2016-09-10 18:06:07 +02:00
1 parent f8c537aaff
commit 8390c7da68
22 files changed
+146 -116

No files matched your search

+9 -11
View File
@@ -14,7 +14,7 @@ namespace CUE.NET.Effects
where T : IEffectTarget<T>
{
#region Properties & Fields
private IList<EffectTimeContainer> _effectTimes = new List<EffectTimeContainer>();
/// <summary>
@@ -68,11 +68,10 @@ namespace CUE.NET.Effects
/// <param name="effect">The effect to add.</param>
public void AddEffect(IEffect<T> effect)
{
if (_effectTimes.All(x => x.Effect != effect))
{
effect.OnAttach(EffectTarget);
_effectTimes.Add(new EffectTimeContainer(effect, -1));
}
if (_effectTimes.Any(x => x.Effect == effect)) return;
effect.OnAttach(EffectTarget);
_effectTimes.Add(new EffectTimeContainer(effect, -1));
}
/// <summary>
@@ -82,11 +81,10 @@ namespace CUE.NET.Effects
public void RemoveEffect(IEffect<T> effect)
{
EffectTimeContainer effectTimeToRemove = _effectTimes.FirstOrDefault(x => x.Effect == effect);
if (effectTimeToRemove != null)
{
effect.OnDetach(EffectTarget);
_effectTimes.Remove(effectTimeToRemove);
}
if (effectTimeToRemove == null) return;
effect.OnDetach(EffectTarget);
_effectTimes.Remove(effectTimeToRemove);
}
#endregion
@@ -1,5 +1,6 @@
// ReSharper disable MemberCanBePrivate.Global
// ReSharper disable UnusedAutoPropertyAccessor.Global
// ReSharper disable UnusedMember.Global
using CUE.NET.Groups;
@@ -8,7 +9,7 @@ namespace CUE.NET.Effects
/// <summary>
/// Represents a basic effect targeting an <see cref="ILedGroup"/>.
/// </summary>
public abstract class AbstractKeyGroupEffect : IEffect<ILedGroup>
public abstract class AbstractLedGroupEffect : IEffect<ILedGroup>
{
#region Properties & Fields
+1
View File
@@ -1,5 +1,6 @@
// ReSharper disable UnusedMember.Global
// ReSharper disable UnusedMemberInSuper.Global
// ReSharper disable UnusedParameter.Global
namespace CUE.NET.Effects
{
+3 -1
View File
@@ -1,4 +1,6 @@
namespace CUE.NET.Effects
// ReSharper disable UnusedMember.Global
namespace CUE.NET.Effects
{
/// <summary>
/// Represents a basic effect-target.