Data model node - Fixed pins disconnecting after restart

Data model event node - Fixed pins disconnecting after restart
Node editor - Fixed connecting already connected input pins to an output pin causing a crash
Node editor - Added auto-save every 2 minutes while nodes are open (profiles are already auto-saved whenever you make a change, nodes will get the same treatment later)

src/Artemis.VisualScripting/Nodes/DataModel/DataModelEventCycleNode.cs

@@ -48,9 +48,7 @@ public class DataModelEventCycleNode : Node<DataModelPathEntity, DataModelEventC
     public override void Evaluate()
     {
         object? pathValue = _dataModelPath?.GetValue();
-        bool hasTriggered = pathValue is IDataModelEvent dataModelEvent
-            ? EvaluateEvent(dataModelEvent)
-            : EvaluateValue(pathValue);
+        bool hasTriggered = pathValue is IDataModelEvent dataModelEvent ? EvaluateEvent(dataModelEvent) : EvaluateValue(pathValue);
 
         if (hasTriggered)
         {

src/Artemis.VisualScripting/Nodes/DataModel/DataModelEventNode.cs

@@ -1,7 +1,6 @@
 using System.Linq.Expressions;
 using System.Reflection;
 using Artemis.Core;
-using Artemis.Core.Events;
 using Artemis.Core.Modules;
 using Artemis.Storage.Entities.Profile;
 using Artemis.VisualScripting.Nodes.DataModel.Screens;
@@ -41,6 +40,47 @@ public class DataModelEventNode : Node<DataModelPathEntity, DataModelEventNodeCu
         UpdateDataModelPath();
     }
 
+    public override void Evaluate()
+    {
+        object? pathValue = _dataModelPath?.GetValue();
+        if (pathValue is not IDataModelEvent dataModelEvent)
+            return;
+
+        TimeSinceLastTrigger.Value = new Numeric(dataModelEvent.TimeSinceLastTrigger.TotalMilliseconds);
+        TriggerCount.Value = new Numeric(dataModelEvent.TriggerCount);
+        
+        foreach ((Func<DataModelEventArgs, object> propertyAccessor, OutputPin outputPin) in _propertyPins)
+        {
+            if (!outputPin.ConnectedTo.Any())
+                continue;
+            object value = dataModelEvent.LastEventArgumentsUntyped != null ? propertyAccessor(dataModelEvent.LastEventArgumentsUntyped) : outputPin.Type.GetDefault()!;
+            outputPin.Value = outputPin.IsNumeric ? new Numeric(value) : value;
+        }
+    }
+
+    private void UpdateDataModelPath()
+    {
+        DataModelPath? old = _dataModelPath;
+        _dataModelPath = Storage != null ? new DataModelPath(Storage) : null;
+        if (_dataModelPath != null)
+            _dataModelPath.PathValidated += DataModelPathOnPathValidated;
+        
+        if (old != null)
+        {
+            old.PathValidated -= DataModelPathOnPathValidated;
+            old.Dispose();
+        }
+        
+        UpdateOutputPins();
+    }
+
+    private void UpdateOutputPins()
+    {
+        object? pathValue = _dataModelPath?.GetValue();
+        if (pathValue is IDataModelEvent dataModelEvent)
+            CreatePins(dataModelEvent);
+    }
+    
     private void CreatePins(IDataModelEvent? dataModelEvent)
     {
         if (_dataModelEvent == dataModelEvent)
@@ -72,34 +112,12 @@ public class DataModelEventNode : Node<DataModelPathEntity, DataModelEventNodeCu
             _propertyPins.Add(expression, CreateOrAddOutputPin(propertyInfo.PropertyType, propertyInfo.Name.Humanize()));
         }
     }
-
-    public override void Evaluate()
+    
+    private void DataModelPathOnPathValidated(object? sender, EventArgs e)
     {
-        object? pathValue = _dataModelPath?.GetValue();
-        if (pathValue is not IDataModelEvent dataModelEvent)
-            return;
-
-        TimeSinceLastTrigger.Value = new Numeric(dataModelEvent.TimeSinceLastTrigger.TotalMilliseconds);
-        TriggerCount.Value = new Numeric(dataModelEvent.TriggerCount);
-        
-        foreach ((Func<DataModelEventArgs, object> propertyAccessor, OutputPin outputPin) in _propertyPins)
-        {
-            if (!outputPin.ConnectedTo.Any())
-                continue;
-            object value = dataModelEvent.LastEventArgumentsUntyped != null ? propertyAccessor(dataModelEvent.LastEventArgumentsUntyped) : outputPin.Type.GetDefault()!;
-            outputPin.Value = outputPin.IsNumeric ? new Numeric(value) : value;
-        }
-    }
-
-    private void UpdateDataModelPath()
-    {
-        DataModelPath? old = _dataModelPath;
-        _dataModelPath = Storage != null ? new DataModelPath(Storage) : null;
-        old?.Dispose();
-
-        object? pathValue = _dataModelPath?.GetValue();
-        if (pathValue is IDataModelEvent dataModelEvent)
-            CreatePins(dataModelEvent);
+        // Update the output pin now that the type is known and attempt to restore the connection that was likely missing
+        UpdateOutputPins();
+        Script?.LoadConnections();
     }
 
     /// <inheritdoc />

src/Artemis.VisualScripting/Nodes/DataModel/DataModelNode.cs

@@ -1,7 +1,6 @@
 using Artemis.Core;
 using Artemis.Storage.Entities.Profile;
 using Artemis.VisualScripting.Nodes.DataModel.Screens;
-using Avalonia.Threading;
 
 namespace Artemis.VisualScripting.Nodes.DataModel;
 
@@ -61,17 +60,24 @@ public class DataModelNode : Node<DataModelPathEntity, DataModelNodeCustomViewMo
     private void UpdateDataModelPath()
     {
         DataModelPath? old = _dataModelPath;
-        old?.Dispose();
-
         _dataModelPath = Storage != null ? new DataModelPath(Storage) : null;
         if (_dataModelPath != null)
             _dataModelPath.PathValidated += DataModelPathOnPathValidated;
+        
+        if (old != null)
+        {
+            old.PathValidated -= DataModelPathOnPathValidated;
+            old.Dispose();
+        }
+        
         UpdateOutputPin();
     }
 
     private void DataModelPathOnPathValidated(object? sender, EventArgs e)
     {
-        Dispatcher.UIThread.InvokeAsync(UpdateOutputPin);
+        // Update the output pin now that the type is known and attempt to restore the connection that was likely missing
+        UpdateOutputPin();
+        Script?.LoadConnections();
     }
 
     /// <inheritdoc />