From 34b04523dee0afefeabe29ceb5ba48124082648d Mon Sep 17 00:00:00 2001 From: Diogo Trindade Date: Wed, 18 Jun 2025 19:31:00 +0100 Subject: [PATCH] make wootingcolor readonly, use int for array index --- .../Grpc/WootingGrpcDeviceProvider.cs | 2 +- .../Grpc/WootingGrpcUpdateQueue.cs | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/RGB.NET.Devices.Wooting/Grpc/WootingGrpcDeviceProvider.cs b/RGB.NET.Devices.Wooting/Grpc/WootingGrpcDeviceProvider.cs index d13433c..2ad96b1 100644 --- a/RGB.NET.Devices.Wooting/Grpc/WootingGrpcDeviceProvider.cs +++ b/RGB.NET.Devices.Wooting/Grpc/WootingGrpcDeviceProvider.cs @@ -66,7 +66,7 @@ public sealed class WootingGrpcDeviceProvider : AbstractRGBDeviceProvider _client = new RgbSdkService.RgbSdkServiceClient(_channel); } - /// + /// protected override IEnumerable LoadDevices() { ArgumentNullException.ThrowIfNull(_client, nameof(_client)); diff --git a/RGB.NET.Devices.Wooting/Grpc/WootingGrpcUpdateQueue.cs b/RGB.NET.Devices.Wooting/Grpc/WootingGrpcUpdateQueue.cs index cdc2cfd..83ff7b9 100644 --- a/RGB.NET.Devices.Wooting/Grpc/WootingGrpcUpdateQueue.cs +++ b/RGB.NET.Devices.Wooting/Grpc/WootingGrpcUpdateQueue.cs @@ -48,7 +48,7 @@ public sealed class WootingGrpcUpdateQueue : UpdateQueue foreach ((object key, Color color) in dataSet) { (int row, int column) = ((int, int))key; - long index = (WootingLedMappings.COLUMNS * row) + column; + int index = (WootingLedMappings.COLUMNS * row) + column; _colors[index] = new WootingColor(color.GetR(), color.GetG(), color.GetB()); } @@ -79,12 +79,12 @@ public sealed class WootingGrpcUpdateQueue : UpdateQueue } [StructLayout(LayoutKind.Sequential, Pack = 1)] -internal struct WootingColor +internal readonly struct WootingColor { - public byte r; - public byte g; - public byte b; - public byte a; + public readonly byte r; + public readonly byte g; + public readonly byte b; + public readonly byte a; public WootingColor(byte r, byte g, byte b) { @@ -94,4 +94,3 @@ internal struct WootingColor this.a = 0; // Alpha is not used in Wooting devices } } -