Sealed a lot of classes that are not meant to be inherited

2026-11-10 20:46:24 +00:00 · 2023-04-19 21:19:05 +02:00
1 parent d9c244a044
commit 2020992249
@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair cooler.
 /// </summary>
-public class CorsairCoolerRGBDevice : CorsairRGBDevice<CorsairCoolerRGBDeviceInfo>, ICooler
+public sealed class CorsairCoolerRGBDevice : CorsairRGBDevice<CorsairCoolerRGBDeviceInfo>, ICooler
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairCoolerRGBDevice" />.
 /// </summary>
-public class CorsairCoolerRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairCoolerRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -13,7 +13,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a device provider responsible for corsair (CUE) devices.
 /// </summary>
-public class CorsairDeviceProvider : AbstractRGBDeviceProvider
+public sealed class CorsairDeviceProvider : AbstractRGBDeviceProvider
 {
    #region Properties & Fields

@@ -306,8 +306,6 @@ public class CorsairDeviceProvider : AbstractRGBDeviceProvider

        try { _CUESDK.CorsairDisconnect(); } catch { /* at least we tried */ }
        try { _CUESDK.UnloadCUESDK(); } catch { /* at least we tried */ }
-
-        GC.SuppressFinalize(this);
    }

    #endregion
@@ -9,7 +9,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents an exception thrown by the CUE.
 /// </summary>
-public class CUEException : ApplicationException
+public sealed class CUEException : ApplicationException
 {
    #region Properties & Fields

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair fan.
 /// </summary>
-public class CorsairFanRGBDevice : CorsairRGBDevice<CorsairFanRGBDeviceInfo>, IFan
+public sealed class CorsairFanRGBDevice : CorsairRGBDevice<CorsairFanRGBDeviceInfo>, IFan
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairFanRGBDevice" />.
 /// </summary>
-public class CorsairFanRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairFanRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -9,7 +9,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents the update-queue performing updates for corsair devices.
 /// </summary>
-public class CorsairDeviceUpdateQueue : UpdateQueue
+public sealed class CorsairDeviceUpdateQueue : UpdateQueue
 {
    #region Properties & Fields

@@ -76,8 +76,6 @@ public class CorsairDeviceUpdateQueue : UpdateQueue

        _isDisposed = true;
        Marshal.FreeHGlobal(_colorPtr);
-
-        GC.SuppressFinalize(this);
    }

    #endregion
@@ -7,7 +7,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents version information for the Corsair-SDK
 /// </summary>
-public class CorsairSessionDetails
+public sealed class CorsairSessionDetails
 {
    #region Properties & Fields

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair graphics card.
 /// </summary>
-public class CorsairGraphicsCardRGBDevice : CorsairRGBDevice<CorsairGraphicsCardRGBDeviceInfo>, IGraphicsCard
+public sealed class CorsairGraphicsCardRGBDevice : CorsairRGBDevice<CorsairGraphicsCardRGBDeviceInfo>, IGraphicsCard
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairGraphicsCardRGBDevice" />.
 /// </summary>
-public class CorsairGraphicsCardRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairGraphicsCardRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair headset.
 /// </summary>
-public class CorsairHeadsetRGBDevice : CorsairRGBDevice<CorsairHeadsetRGBDeviceInfo>, IHeadset
+public sealed class CorsairHeadsetRGBDevice : CorsairRGBDevice<CorsairHeadsetRGBDeviceInfo>, IHeadset
 {
    #region Constructors

@@ -7,7 +7,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairHeadsetRGBDevice" />.
 /// </summary>
-public class CorsairHeadsetRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairHeadsetRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair headset stand.
 /// </summary>
-public class CorsairHeadsetStandRGBDevice : CorsairRGBDevice<CorsairHeadsetStandRGBDeviceInfo>, IHeadsetStand
+public sealed class CorsairHeadsetStandRGBDevice : CorsairRGBDevice<CorsairHeadsetStandRGBDeviceInfo>, IHeadsetStand
 {
    #region Constructors

@@ -7,7 +7,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairHeadsetStandRGBDevice" />.
 /// </summary>
-public class CorsairHeadsetStandRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairHeadsetStandRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair keyboard.
 /// </summary>
-public class CorsairKeyboardRGBDevice : CorsairRGBDevice<CorsairKeyboardRGBDeviceInfo>, IKeyboard
+public sealed class CorsairKeyboardRGBDevice : CorsairRGBDevice<CorsairKeyboardRGBDeviceInfo>, IKeyboard
 {
    #region Properties & Fields

@@ -9,7 +9,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairKeyboardRGBDevice" />.
 /// </summary>
-public class CorsairKeyboardRGBDeviceInfo : CorsairRGBDeviceInfo, IKeyboardDeviceInfo
+public sealed class CorsairKeyboardRGBDeviceInfo : CorsairRGBDeviceInfo, IKeyboardDeviceInfo
 {
    #region Properties & Fields

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair ledStrip.
 /// </summary>
-public class CorsairLedStripRGBDevice : CorsairRGBDevice<CorsairLedStripRGBDeviceInfo>, ILedStripe
+public sealed class CorsairLedStripRGBDevice : CorsairRGBDevice<CorsairLedStripRGBDeviceInfo>, ILedStripe
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairLedStripRGBDevice" />.
 /// </summary>
-public class CorsairLedStripRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairLedStripRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair memory.
 /// </summary>
-public class CorsairMainboardRGBDevice : CorsairRGBDevice<CorsairMainboardRGBDeviceInfo>, IMainboard
+public sealed class CorsairMainboardRGBDevice : CorsairRGBDevice<CorsairMainboardRGBDeviceInfo>, IMainboard
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairMainboardRGBDevice" />.
 /// </summary>
-public class CorsairMainboardRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairMainboardRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair memory.
 /// </summary>
-public class CorsairMemoryRGBDevice : CorsairRGBDevice<CorsairMemoryRGBDeviceInfo>, IDRAM
+public sealed class CorsairMemoryRGBDevice : CorsairRGBDevice<CorsairMemoryRGBDeviceInfo>, IDRAM
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairMemoryRGBDevice" />.
 /// </summary>
-public class CorsairMemoryRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairMemoryRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair mouse.
 /// </summary>
-public class CorsairMouseRGBDevice : CorsairRGBDevice<CorsairMouseRGBDeviceInfo>, IMouse
+public sealed class CorsairMouseRGBDevice : CorsairRGBDevice<CorsairMouseRGBDeviceInfo>, IMouse
 {
    #region Constructors

@@ -7,7 +7,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairMouseRGBDevice" />.
 /// </summary>
-public class CorsairMouseRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairMouseRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair mousepad.
 /// </summary>
-public class CorsairMousepadRGBDevice : CorsairRGBDevice<CorsairMousepadRGBDeviceInfo>, IMousepad
+public sealed class CorsairMousepadRGBDevice : CorsairRGBDevice<CorsairMousepadRGBDeviceInfo>, IMousepad
 {
    #region Constructors

@@ -7,7 +7,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairMousepadRGBDevice" />.
 /// </summary>
-public class CorsairMousepadRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairMousepadRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -12,7 +12,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains device search filter
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairDeviceFilter
+internal sealed class _CorsairDeviceFilter
 {
    #region Properties & Fields

@@ -12,7 +12,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains information about device
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairDeviceInfo
+internal sealed class _CorsairDeviceInfo
 {
    /// <summary>
    /// iCUE-SDK: enum describing device type
@@ -13,7 +13,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains led id and position of led
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairLedPosition
+internal sealed class _CorsairLedPosition
 {
    /// <summary>
    /// iCUE-SDK: unique identifier of led
@@ -13,7 +13,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains information about SDK and iCUE versions
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairSessionDetails
+internal sealed class _CorsairSessionDetails
 {
    /// <summary>
    /// iCUE-SDK: version of SDK client (like {4,0,1}). Always contains valid value even if there was no iCUE found. Must comply with the semantic versioning rules.
@@ -13,7 +13,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains information about session state and client/server versions
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairSessionStateChanged
+internal sealed class _CorsairSessionStateChanged
 {
    /// <summary>
    /// iCUE-SDK: new session state which SDK client has been transitioned to
@@ -13,7 +13,7 @@ namespace RGB.NET.Devices.Corsair.Native;
 /// iCUE-SDK: contains information about version that consists of three components
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal class _CorsairVersion
+internal sealed class _CorsairVersion
 {
    #region Properties & Fields

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a corsair touchbar.
 /// </summary>
-public class CorsairTouchbarRGBDevice : CorsairRGBDevice<CorsairTouchbarRGBDeviceInfo>, ILedStripe
+public sealed class CorsairTouchbarRGBDevice : CorsairRGBDevice<CorsairTouchbarRGBDeviceInfo>, ILedStripe
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairTouchbarRGBDevice" />.
 /// </summary>
-public class CorsairTouchbarRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairTouchbarRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a unknown corsair device.
 /// </summary>
-public class CorsairUnknownRGBDevice : CorsairRGBDevice<CorsairUnknownRGBDeviceInfo>, IUnknownDevice
+public sealed class CorsairUnknownRGBDevice : CorsairRGBDevice<CorsairUnknownRGBDeviceInfo>, IUnknownDevice
 {
    #region Constructors

@@ -10,7 +10,7 @@ namespace RGB.NET.Devices.Corsair;
 /// <summary>
 /// Represents a generic information for a <see cref="T:RGB.NET.Devices.Corsair.CorsairUnknownRGBDevice" />.
 /// </summary>
-public class CorsairUnknownRGBDeviceInfo : CorsairRGBDeviceInfo
+public sealed class CorsairUnknownRGBDeviceInfo : CorsairRGBDeviceInfo
 {
    #region Constructors