DarthAffe/HPPH
1
0
Fork 0
mirror of https://github.com/DarthAffe/HPPH.git synced 2025-12-12 13:28:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9 from DarthAffe/PerformanceImprovements

Browse Source 
Changed array allocations for copying potentionally big data (like whole images) to be uninitialized allocation
This commit is contained in:
DarthAffe 2024-09-15 12:00:16 +02:00 committed by GitHub
commit da26ca248f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
HPPH/Images/Image.cs
View File

@ -124,7 +124,7 @@ public sealed class Image<T> : IImage<T>, IEquatable<Image<T>>
if (stride < width) throw new ArgumentException("Stride can't be smaller than width."); if (stride < width) throw new ArgumentException("Stride can't be smaller than width.");
if (buffer.Length < (height * stride)) throw new ArgumentException("Not enough data in the buffer."); if (buffer.Length < (height * stride)) throw new ArgumentException("Not enough data in the buffer.");
byte[] data = new byte[buffer.Length]; byte[] data = GC.AllocateUninitializedArray<byte>(buffer.Length);
buffer.CopyTo(data); buffer.CopyTo(data);
return new Image<T>(data, 0, 0, width, height, stride); return new Image<T>(data, 0, 0, width, height, stride);
} }
@ -152,7 +152,7 @@ public sealed class Image<T> : IImage<T>, IEquatable<Image<T>>
else else
{ {
byte[] data = ToRawArray(); byte[] data = ToRawArray();
byte[] target = new byte[Width * Height * targetBpp]; byte[] target = GC.AllocateUninitializedArray<byte>(Width * Height * targetBpp);
MemoryMarshal.Cast<byte, T>(data.AsSpan()).Convert(MemoryMarshal.Cast<byte, TColor>(target)); MemoryMarshal.Cast<byte, T>(data.AsSpan()).Convert(MemoryMarshal.Cast<byte, TColor>(target));
return new Image<TColor>(target, 0, 0, Width, Height, Width * targetBpp); return new Image<TColor>(target, 0, 0, Width, Height, Width * targetBpp);
} }
@ -180,7 +180,7 @@ public sealed class Image<T> : IImage<T>, IEquatable<Image<T>>
/// <inheritdoc /> /// <inheritdoc />
public byte[] ToRawArray() public byte[] ToRawArray()
{ {
byte[] array = new byte[SizeInBytes]; byte[] array = GC.AllocateUninitializedArray<byte>(SizeInBytes);
CopyTo(array); CopyTo(array);
return array; return array;
} }
@ -188,7 +188,7 @@ public sealed class Image<T> : IImage<T>, IEquatable<Image<T>>
/// <inheritdoc /> /// <inheritdoc />
public T[] ToArray() public T[] ToArray()
{ {
T[] colors = new T[Width * Height]; T[] colors = GC.AllocateUninitializedArray<T>(Width * Height);
CopyTo(colors); CopyTo(colors);
return colors; return colors;
} }

2
HPPH/Images/ImageColumn.cs
View File

@ -64,7 +64,7 @@ public readonly ref struct ImageColumn<T>
public T[] ToArray() public T[] ToArray()
{ {
T[] array = new T[Length]; T[] array = GC.AllocateUninitializedArray<T>(Length);
CopyTo(array); CopyTo(array);
return array; return array;
} }

3
HPPH/Images/ImageRow.cs
View File

@ -62,10 +62,11 @@ public readonly ref struct ImageRow<T>
public T[] ToArray() public T[] ToArray()
{ {
T[] array = new T[Length]; T[] array = GC.AllocateUninitializedArray<T>(Length);
CopyTo(array); CopyTo(array);
return array; return array;
} }
/// <inheritdoc cref="System.Collections.IEnumerable.GetEnumerator"/> /// <inheritdoc cref="System.Collections.IEnumerable.GetEnumerator"/>
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
public ImageRowEnumerator GetEnumerator() => new(this); public ImageRowEnumerator GetEnumerator() => new(this);

2
HPPH/Images/RefImage.cs
View File

@ -128,7 +128,7 @@ public readonly ref struct RefImage<T>
/// <returns>The new array containing the data of this <see cref="RefImage{T}"/>.</returns> /// <returns>The new array containing the data of this <see cref="RefImage{T}"/>.</returns>
public T[] ToArray() public T[] ToArray()
{ {
T[] array = new T[Width * Height]; T[] array = GC.AllocateUninitializedArray<T>(Width * Height);
CopyTo(array); CopyTo(array);
return array; return array;
} }

4
HPPH/PixelHelper.Convert.cs
View File

@ -38,7 +38,7 @@ public static unsafe partial class PixelHelper
{ {
if (colors == null) throw new ArgumentNullException(nameof(colors)); if (colors == null) throw new ArgumentNullException(nameof(colors));
TTarget[] buffer = new TTarget[colors.Length]; TTarget[] buffer = GC.AllocateUninitializedArray<TTarget>(colors.Length);
Convert(colors, buffer.AsSpan()); Convert(colors, buffer.AsSpan());
return buffer; return buffer;
} }
@ -49,7 +49,7 @@ public static unsafe partial class PixelHelper
{ {
if (colors == null) throw new ArgumentNullException(nameof(colors)); if (colors == null) throw new ArgumentNullException(nameof(colors));
TTarget[] buffer = new TTarget[colors.Length]; TTarget[] buffer = GC.AllocateUninitializedArray<TTarget>(colors.Length);
Convert(colors, buffer.AsSpan()); Convert(colors, buffer.AsSpan());
return buffer; return buffer;
} }