From 619b389f7d08ae5d98276e6a18bf64bd2d8eefe0 Mon Sep 17 00:00:00 2001 From: Darth Affe Date: Thu, 5 Jan 2017 16:50:57 +0100 Subject: [PATCH] Fixed some more code issues --- Effects/AbstractEffectTarget.cs | 5 ++++- Effects/FlashEffect.cs | 8 ++++---- Gradients/RainbowGradient.cs | 2 +- Groups/ListLedGroup.cs | 3 +++ Groups/RectangleLedGroup.cs | 4 ++++ 5 files changed, 16 insertions(+), 6 deletions(-) diff --git a/Effects/AbstractEffectTarget.cs b/Effects/AbstractEffectTarget.cs index 61cd5b5..bee181b 100644 --- a/Effects/AbstractEffectTarget.cs +++ b/Effects/AbstractEffectTarget.cs @@ -16,7 +16,10 @@ namespace CUE.NET.Effects { #region Properties & Fields - protected IList EffectTimes = new List(); + /// + /// Gets a list of storing the attached effects. + /// + protected IList EffectTimes { get; } = new List(); /// /// Gets all attached to this target. diff --git a/Effects/FlashEffect.cs b/Effects/FlashEffect.cs index 343f201..f5e1bdf 100644 --- a/Effects/FlashEffect.cs +++ b/Effects/FlashEffect.cs @@ -16,26 +16,26 @@ namespace CUE.NET.Effects /// /// Gets or sets the attack-time (in seconds) of the effect. (default: 0.2f)
- /// This is close to a synthesizer envelope. (See as reference) + /// This is close to a synthesizer envelope. (See as reference) ///
public float Attack { get; set; } = 0.2f; /// /// Gets or sets the decay-time (in seconds) of the effect. (default: 0f)
- /// This is close to a synthesizer envelope. (See as reference) + /// This is close to a synthesizer envelope. (See as reference) ///
public float Decay { get; set; } = 0f; /// /// Gets or sets the sustain-time (in seconds) of the effect. (default: 0.3f)
- /// This is close to a synthesizer envelope. (See as reference)
+ /// This is close to a synthesizer envelope. (See as reference)
/// Note that this value for naming reasons represents the time NOT the level. ///
public float Sustain { get; set; } = 0.3f; /// /// Gets or sets the release-time (in seconds) of the effect. (default: 0.2f)
- /// This is close to a synthesizer envelope. (See as reference) + /// This is close to a synthesizer envelope. (See as reference) ///
public float Release { get; set; } = 0.2f; diff --git a/Gradients/RainbowGradient.cs b/Gradients/RainbowGradient.cs index 740908c..bd0e7d9 100644 --- a/Gradients/RainbowGradient.cs +++ b/Gradients/RainbowGradient.cs @@ -8,7 +8,7 @@ namespace CUE.NET.Gradients { /// /// Represents a rainbow gradient which circles through all colors of the HUE-color-space.
- /// See as reference + /// See as reference. ///
public class RainbowGradient : IGradient { diff --git a/Groups/ListLedGroup.cs b/Groups/ListLedGroup.cs index 03991da..1ea39f3 100644 --- a/Groups/ListLedGroup.cs +++ b/Groups/ListLedGroup.cs @@ -15,6 +15,9 @@ namespace CUE.NET.Groups { #region Properties & Fields + /// + /// Gets the strongly-typed target used for the effect. + /// protected override ILedGroup EffectTarget => this; /// diff --git a/Groups/RectangleLedGroup.cs b/Groups/RectangleLedGroup.cs index 624cdd2..3845426 100644 --- a/Groups/RectangleLedGroup.cs +++ b/Groups/RectangleLedGroup.cs @@ -98,6 +98,10 @@ namespace CUE.NET.Groups #region Methods + /// + /// Gets a list containing all LEDs of this group. + /// + /// The list containing all LEDs of this group. public override IEnumerable GetLeds() { return _ledCache ?? (_ledCache = Device.Where(x => RectangleHelper.CalculateIntersectPercentage(x.LedRectangle, Rectangle) >= MinOverlayPercentage).ToList());