Refactored shape brushes to use the properties system

src/Artemis.Core/Models/Profile/LayerProperties/BaseLayerProperty.cs

@@ -3,6 +3,7 @@ using System.Collections.Generic;
 using System.Linq;
 using Artemis.Core.Exceptions;
 using Artemis.Core.Models.Profile.KeyframeEngines;
+using Artemis.Core.Plugins.Models;
 using Artemis.Core.Utilities;
 using Artemis.Storage.Entities.Profile;
 using Newtonsoft.Json;
@@ -13,9 +14,10 @@ namespace Artemis.Core.Models.Profile.LayerProperties
     {
         private object _baseValue;
 
-        protected BaseLayerProperty(Layer layer, BaseLayerProperty parent, string id, string name, string description, Type type)
+        protected BaseLayerProperty(Layer layer, PluginInfo pluginInfo, BaseLayerProperty parent, string id, string name, string description, Type type)
         {
             Layer = layer;
+            PluginInfo = pluginInfo;
             Parent = parent;
             Id = id;
             Name = name;
@@ -23,8 +25,14 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             Type = type;
             CanUseKeyframes = true;
 
+            // This can only be null if accessed internally
+            if (PluginInfo == null)
+                PluginInfo = Constants.CorePluginInfo;
+            
             Children = new List<BaseLayerProperty>();
             BaseKeyframes = new List<BaseKeyframe>();
+
+            parent?.Children.Add(this);
         }
 
         /// <summary>
@@ -32,6 +40,11 @@ namespace Artemis.Core.Models.Profile.LayerProperties
         /// </summary>
         public Layer Layer { get; }
 
+        /// <summary>
+        ///     Info of the plugin associated with this property
+        /// </summary>
+        public PluginInfo PluginInfo { get; }
+
         /// <summary>
         ///     Gets the parent property of this property.
         /// </summary>

src/Artemis.Core/Models/Profile/LayerProperties/LayerProperty.cs

@@ -1,14 +1,73 @@
-using System.Collections.ObjectModel;
+using System;
+using System.Collections.ObjectModel;
 using System.Linq;
+using Artemis.Core.Plugins.Models;
 
 namespace Artemis.Core.Models.Profile.LayerProperties
 {
+    /// <summary>
+    ///     Represents a property on the layer. This property is visible in the profile editor and can be key-framed (unless
+    ///     opted out)
+    /// </summary>
+    /// <typeparam name="T"></typeparam>
     public class LayerProperty<T> : BaseLayerProperty
     {
-        public LayerProperty(Layer layer, BaseLayerProperty parent, string id, string name, string description) : base(layer, parent, id, name, description, typeof(T))
+        internal LayerProperty(Layer layer, BaseLayerProperty parent, string id, string name, string description) : base(layer, null, parent, id, name, description, typeof(T))
         {
         }
 
+        internal LayerProperty(Layer layer, string id, string name, string description) : base(layer, null, null, id, name, description, typeof(T))
+        {
+        }
+
+        /// <summary>
+        ///     Represents a property on the layer. This property is visible in the profile editor and can be key-framed (unless
+        ///     opted out)
+        ///     <para>
+        ///         Note: The value and keyframes of the property are stored using the ID, after adding the property to the layer
+        ///         these are restored.
+        ///     </para>
+        /// </summary>
+        /// <param name="layer">The layer the property is applied to</param>
+        /// <param name="pluginInfo">The plugin to create this property for</param>
+        /// <param name="parent">The parent of this property, use this to create a tree-hierarchy in the editor</param>
+        /// <param name="id">A and ID identifying your property, must be unique within your plugin</param>
+        /// <param name="name">A name for your property, this is visible in the editor</param>
+        /// <param name="description">A description for your property, this is visible in the editor</param>
+        public LayerProperty(Layer layer, PluginInfo pluginInfo, BaseLayerProperty parent, string id, string name, string description) : base(layer, pluginInfo, parent, id, name, description,
+            typeof(T))
+        {
+            if (layer == null)
+                throw new ArgumentNullException(nameof(layer));
+            if (pluginInfo == null)
+                throw new ArgumentNullException(nameof(pluginInfo));
+            if (id == null)
+                throw new ArgumentNullException(nameof(id));
+        }
+
+        /// <summary>
+        ///     Represents a property on the layer. This property is visible in the profile editor and can be key-framed (unless
+        ///     opted out)
+        ///     <para>
+        ///         Note: The value and keyframes of the property are stored using the ID, after adding the property to the layer
+        ///         these are restored.
+        ///     </para>
+        /// </summary>
+        /// <param name="layer">The layer the property is applied to</param>
+        /// <param name="pluginInfo">The plugin to create this property for</param>
+        /// <param name="id">A and ID identifying your property, must be unique within your plugin</param>
+        /// <param name="name">A name for your property, this is visible in the editor</param>
+        /// <param name="description">A description for your property, this is visible in the editor</param>
+        public LayerProperty(Layer layer, PluginInfo pluginInfo, string id, string name, string description) : base(layer, pluginInfo, null, id, name, description, typeof(T))
+        {
+            if (layer == null)
+                throw new ArgumentNullException(nameof(layer));
+            if (pluginInfo == null)
+                throw new ArgumentNullException(nameof(pluginInfo));
+            if (id == null)
+                throw new ArgumentNullException(nameof(id));
+        }
+
         /// <summary>
         ///     Gets or sets the value of the property without any keyframes applied
         /// </summary>