DarthAffe/Artemis
1
0
Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2025-12-31 17:53:32 +00:00
Code Issues Releases Wiki Activity

Core - Log exceptions in timed updates, this closes #508

Browse Source
This commit is contained in:
SpoinkyNL 2021-01-16 18:18:27 +01:00
parent 467473f06c
commit ea6c081f22
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/Artemis.Core/Plugins/TimedUpdateRegistration.cs
View File

@ -2,6 +2,9 @@
using System.Threading.Tasks; using System.Threading.Tasks;
using System.Timers; using System.Timers;
using Artemis.Core.Modules; using Artemis.Core.Modules;
using Artemis.Core.Services;
using Ninject;
using Serilog;
namespace Artemis.Core namespace Artemis.Core
{ {
@ -14,9 +17,12 @@ namespace Artemis.Core
private Timer? _timer; private Timer? _timer;
private bool _disposed; private bool _disposed;
private readonly object _lock = new(); private readonly object _lock = new();
private ILogger _logger;
internal TimedUpdateRegistration(PluginFeature feature, TimeSpan interval, Action<double> action) internal TimedUpdateRegistration(PluginFeature feature, TimeSpan interval, Action<double> action)
{ {
_logger = CoreService.Kernel.Get<ILogger>();
Feature = feature; Feature = feature;
Interval = interval; Interval = interval;
Action = action; Action = action;
@ -119,12 +125,19 @@ namespace Artemis.Core
if (Feature is Module module && !module.IsUpdateAllowed) if (Feature is Module module && !module.IsUpdateAllowed)
return; return;
if (Action != null) try
Action(interval.TotalSeconds);
else if (AsyncAction != null)
{ {
Task task = AsyncAction(interval.TotalSeconds); if (Action != null)
task.Wait(); Action(interval.TotalSeconds);
else if (AsyncAction != null)
{
Task task = AsyncAction(interval.TotalSeconds);
task.Wait();
}
}
catch (Exception exception)
{
_logger.Error(exception, "Timed update uncaught exception in plugin {plugin}", Feature.Plugin);
} }
} }
} }