DarthAffe/Artemis
1
0
Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2025-12-13 05:48:35 +00:00
Code Issues Releases Wiki Activity

Modules UI - Fixed activation view not subscribing sometimes

Browse Source 
Core - Don't attempt to catch a timeout during module override, only pain down that route
This commit is contained in:
SpoinkyNL 2020-08-26 22:16:30 +02:00
parent 8d756128e4
commit d62d389d9f
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Artemis.Core/Services/ModuleService.cs
View File

@ -44,12 +44,11 @@ namespace Artemis.Core.Services
public async Task SetActiveModuleOverride(Module overrideModule) public async Task SetActiveModuleOverride(Module overrideModule)
{ {
await ActiveModuleSemaphore.WaitAsync();
if (ActiveModuleOverride == overrideModule) if (ActiveModuleOverride == overrideModule)
return; return;
if (!await ActiveModuleSemaphore.WaitAsync(TimeSpan.FromSeconds(10)))
throw new ArtemisCoreException("Timed out while acquiring active module lock");
try try
{ {
ActiveModuleOverride = overrideModule; ActiveModuleOverride = overrideModule;
@ -92,8 +91,7 @@ namespace Artemis.Core.Services
if (ActiveModuleOverride != null) if (ActiveModuleOverride != null)
return; return;
if (!await ActiveModuleSemaphore.WaitAsync(TimeSpan.FromSeconds(10))) await ActiveModuleSemaphore.WaitAsync();
throw new ArtemisCoreException("Timed out while acquiring active module lock");
try try
{ {

6
src/Artemis.UI/Screens/Module/Tabs/ActivationRequirementsViewModel.cs
View File

@ -27,10 +27,8 @@ namespace Artemis.UI.Screens.Module.Tabs
protected override void OnActivate() protected override void OnActivate()
{ {
if (!Items.Any()) Items.Clear();
Items.AddRange(Module.ActivationRequirements.Select(_moduleVmFactory.CreateActivationRequirementViewModel)); Items.AddRange(Module.ActivationRequirements.Select(_moduleVmFactory.CreateActivationRequirementViewModel));
} }
} }
} }