Profile editor - Finished most of the refactor except databindings

src/Artemis.UI/Screens/ProfileEditor/LayerProperties/Timeline/TimelineSegmentViewModel.cs

@@ -17,6 +17,10 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
         private bool _showDisableButton;
         private bool _showRepeatButton;
         private bool _showSegmentName;
+        private TimeSpan _segmentLength;
+        private double _segmentWidth;
+        private bool _segmentEnabled;
+        private double _segmentStartPosition;
 
         public TimelineSegmentViewModel(SegmentViewModelType segment, BindableCollection<LayerPropertyGroupViewModel> layerPropertyGroups,
             IProfileEditorService profileEditorService)
@@ -24,55 +28,54 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
             ProfileEditorService = profileEditorService;
             Segment = segment;
             LayerPropertyGroups = layerPropertyGroups;
-            SelectedProfileElement = ProfileEditorService.SelectedProfileElement;
 
-            switch (Segment)
-            {
-                case SegmentViewModelType.Start:
-                    ToolTip = "This segment is played when a layer starts displaying because it's conditions are met";
-                    break;
-                case SegmentViewModelType.Main:
-                    ToolTip = "This segment is played while a condition is met, either once or on a repeating loop";
-                    break;
-                case SegmentViewModelType.End:
-                    ToolTip = "This segment is played once a condition is no longer met";
-                    break;
-                default:
-                    throw new ArgumentOutOfRangeException(nameof(segment));
-            }
+            if (Segment == SegmentViewModelType.Start)
+                ToolTip = "This segment is played when a layer starts displaying because it's conditions are met";
+            else if (Segment == SegmentViewModelType.Main)
+                ToolTip = "This segment is played while a condition is met, either once or on a repeating loop";
+            else if (Segment == SegmentViewModelType.End)
+                ToolTip = "This segment is played once a condition is no longer met";
+            IsMainSegment = Segment == SegmentViewModelType.Main;
 
-            UpdateDisplay();
             ProfileEditorService.PixelsPerSecondChanged += ProfileEditorServiceOnPixelsPerSecondChanged;
             ProfileEditorService.ProfileElementSelected += ProfileEditorServiceOnProfileElementSelected;
             if (ProfileEditorService.SelectedProfileElement != null)
                 ProfileEditorService.SelectedProfileElement.PropertyChanged += SelectedProfileElementOnPropertyChanged;
+
+            Update();
         }
 
-        public RenderProfileElement SelectedProfileElement { get; }
-
+        public RenderProfileElement SelectedProfileElement => ProfileEditorService.SelectedProfileElement;
         public SegmentViewModelType Segment { get; }
         public BindableCollection<LayerPropertyGroupViewModel> LayerPropertyGroups { get; }
         public IProfileEditorService ProfileEditorService { get; }
+
         public string ToolTip { get; }
+        public bool IsMainSegment { get; }
 
         public TimeSpan SegmentLength
         {
-            get
-            {
-                return Segment switch
-                {
-                    SegmentViewModelType.Start => SelectedProfileElement?.StartSegmentLength ?? TimeSpan.Zero,
-                    SegmentViewModelType.Main => SelectedProfileElement?.MainSegmentLength ?? TimeSpan.Zero,
-                    SegmentViewModelType.End => SelectedProfileElement?.EndSegmentLength ?? TimeSpan.Zero,
-                    _ => throw new ArgumentOutOfRangeException()
-                };
-            }
+            get => _segmentLength;
+            set => SetAndNotify(ref _segmentLength, value);
         }
 
-        public double SegmentWidth => ProfileEditorService.PixelsPerSecond * SegmentLength.TotalSeconds;
+        public double SegmentWidth
+        {
+            get => _segmentWidth;
+            set => SetAndNotify(ref _segmentWidth, value);
+        }
 
-        public bool SegmentEnabled => SegmentLength != TimeSpan.Zero;
-        public bool IsMainSegment => Segment == SegmentViewModelType.Main;
+        public double SegmentStartPosition
+        {
+            get => _segmentStartPosition;
+            set => SetAndNotify(ref _segmentStartPosition, value);
+        }
+
+        public bool SegmentEnabled
+        {
+            get => _segmentEnabled;
+            set => SetAndNotify(ref _segmentEnabled, value);
+        }
 
         // Only the main segment supports this, for any other segment the getter always returns false and the setter does nothing
         public bool RepeatSegment
@@ -95,23 +98,6 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
             }
         }
 
-        public double SegmentStartPosition
-        {
-            get
-            {
-                if (SelectedProfileElement == null)
-                    return 0;
-
-                return Segment switch
-                {
-                    SegmentViewModelType.Start => 0,
-                    SegmentViewModelType.Main => ProfileEditorService.PixelsPerSecond * SelectedProfileElement.StartSegmentLength.TotalSeconds,
-                    SegmentViewModelType.End => ProfileEditorService.PixelsPerSecond * (SelectedProfileElement.StartSegmentLength.TotalSeconds + SelectedProfileElement.MainSegmentLength.TotalSeconds),
-                    _ => throw new ArgumentOutOfRangeException()
-                };
-            }
-        }
-
         public bool ShowSegmentName
         {
             get => _showSegmentName;
@@ -130,14 +116,57 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
             set => SetAndNotify(ref _showDisableButton, value);
         }
 
-        public void Dispose()
+        #region Updating
+
+        private void UpdateHeader()
         {
-            ProfileEditorService.PixelsPerSecondChanged -= ProfileEditorServiceOnPixelsPerSecondChanged;
-            ProfileEditorService.ProfileElementSelected -= ProfileEditorServiceOnProfileElementSelected;
-            if (SelectedProfileElement != null)
-                SelectedProfileElement.PropertyChanged -= SelectedProfileElementOnPropertyChanged;
+            if (!IsMainSegment)
+                ShowSegmentName = SegmentWidth > 60;
+            else
+                ShowSegmentName = SegmentWidth > 80;
+
+            ShowRepeatButton = SegmentWidth > 45 && IsMainSegment;
+            ShowDisableButton = SegmentWidth > 25;
         }
 
+        private void Update()
+        {
+            if (SelectedProfileElement == null)
+            {
+                SegmentLength = TimeSpan.Zero;
+                SegmentStartPosition = 0;
+                SegmentWidth = 0;
+                SegmentEnabled = false;
+                return;
+            }
+
+            if (Segment == SegmentViewModelType.Start)
+            {
+                SegmentLength = SelectedProfileElement.StartSegmentLength;
+                SegmentStartPosition = 0;
+            }
+            else if (Segment == SegmentViewModelType.Main)
+            {
+                SegmentLength = SelectedProfileElement.MainSegmentLength;
+                SegmentStartPosition = ProfileEditorService.PixelsPerSecond * SelectedProfileElement.StartSegmentLength.TotalSeconds;
+            }
+            else if (Segment == SegmentViewModelType.End)
+            {
+                SegmentLength = SelectedProfileElement.EndSegmentLength;
+                SegmentStartPosition = ProfileEditorService.PixelsPerSecond * (SelectedProfileElement.StartSegmentLength.TotalSeconds +
+                                                                               SelectedProfileElement.MainSegmentLength.TotalSeconds);
+            }
+
+            SegmentWidth = ProfileEditorService.PixelsPerSecond * SegmentLength.TotalSeconds;
+            SegmentEnabled = SegmentLength != TimeSpan.Zero;
+
+            UpdateHeader();
+        }
+
+        #endregion
+
+        #region Controls
+
         public void DisableSegment()
         {
             var startSegmentEnd = SelectedProfileElement.StartSegmentLength;
@@ -164,9 +193,9 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
                 SelectedProfileElement.EndSegmentLength = TimeSpan.Zero;
             }
 
-            NotifyOfPropertyChange(nameof(SegmentEnabled));
             ShiftNextSegment(SegmentLength - oldSegmentLength);
             ProfileEditorService.UpdateSelectedProfileElement();
+            Update();
         }
 
         public void EnableSegment()
@@ -179,23 +208,13 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
             else if (Segment == SegmentViewModelType.End)
                 SelectedProfileElement.EndSegmentLength = TimeSpan.FromSeconds(1);
 
-            NotifyOfPropertyChange(nameof(SegmentEnabled));
             ProfileEditorService.UpdateSelectedProfileElement();
-            UpdateDisplay();
+            Update();
         }
 
-        public void ShiftNextSegment(TimeSpan amount)
-        {
-            var segmentEnd = TimeSpan.Zero;
-            if (Segment == SegmentViewModelType.Start)
-                segmentEnd = SelectedProfileElement.StartSegmentLength;
-            else if (Segment == SegmentViewModelType.Main)
-                segmentEnd = SelectedProfileElement.StartSegmentLength + SelectedProfileElement.MainSegmentLength;
-            else if (Segment == SegmentViewModelType.End)
-                segmentEnd = SelectedProfileElement.TimelineLength;
+        #endregion
 
-            ShiftKeyframes(segmentEnd, null, amount);
-        }
+        #region Mouse events
 
         public void SegmentMouseDown(object sender, MouseButtonEventArgs e)
         {
@@ -260,18 +279,34 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
                 SelectedProfileElement.EndSegmentLength = newTime - SelectedProfileElement.StartSegmentLength - SelectedProfileElement.MainSegmentLength;
             }
 
-            NotifyOfPropertyChange(nameof(SegmentLength));
-            NotifyOfPropertyChange(nameof(SegmentWidth));
-
             ShiftNextSegment(SegmentLength - oldSegmentLength);
-            UpdateDisplay();
+            Update();
         }
 
+        #endregion
+
+        #region IDIsposable
+
+        public void Dispose()
+        {
+            ProfileEditorService.PixelsPerSecondChanged -= ProfileEditorServiceOnPixelsPerSecondChanged;
+            ProfileEditorService.ProfileElementSelected -= ProfileEditorServiceOnProfileElementSelected;
+            if (SelectedProfileElement != null)
+                SelectedProfileElement.PropertyChanged -= SelectedProfileElementOnPropertyChanged;
+        }
+
+        #endregion
+
+        #region Event handlers
+
         private void ProfileEditorServiceOnProfileElementSelected(object? sender, RenderProfileElementEventArgs e)
         {
             if (e.PreviousRenderProfileElement != null)
                 e.PreviousRenderProfileElement.PropertyChanged -= SelectedProfileElementOnPropertyChanged;
-            e.RenderProfileElement.PropertyChanged += SelectedProfileElementOnPropertyChanged;
+            if (e.RenderProfileElement != null)
+                e.RenderProfileElement.PropertyChanged += SelectedProfileElementOnPropertyChanged;
+
+            Update();
         }
 
         private void SelectedProfileElementOnPropertyChanged(object sender, PropertyChangedEventArgs e)
@@ -279,31 +314,29 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Timeline
             if (e.PropertyName == nameof(RenderProfileElement.StartSegmentLength) ||
                 e.PropertyName == nameof(RenderProfileElement.MainSegmentLength) ||
                 e.PropertyName == nameof(RenderProfileElement.EndSegmentLength))
-            {
-                NotifyOfPropertyChange(nameof(SegmentStartPosition));
-                NotifyOfPropertyChange(nameof(SegmentWidth));
-            }
+                Update();
             else if (e.PropertyName == nameof(RenderProfileElement.DisplayContinuously))
                 NotifyOfPropertyChange(nameof(RepeatSegment));
         }
 
         private void ProfileEditorServiceOnPixelsPerSecondChanged(object? sender, EventArgs e)
         {
-            NotifyOfPropertyChange(nameof(SegmentWidth));
-            NotifyOfPropertyChange(nameof(SegmentStartPosition));
-
-            UpdateDisplay();
+            Update();
         }
 
-        private void UpdateDisplay()
-        {
-            if (!IsMainSegment)
-                ShowSegmentName = SegmentWidth > 60;
-            else
-                ShowSegmentName = SegmentWidth > 80;
+        #endregion
 
-            ShowRepeatButton = SegmentWidth > 45 && IsMainSegment;
-            ShowDisableButton = SegmentWidth > 25;
+        public void ShiftNextSegment(TimeSpan amount)
+        {
+            var segmentEnd = TimeSpan.Zero;
+            if (Segment == SegmentViewModelType.Start)
+                segmentEnd = SelectedProfileElement.StartSegmentLength;
+            else if (Segment == SegmentViewModelType.Main)
+                segmentEnd = SelectedProfileElement.StartSegmentLength + SelectedProfileElement.MainSegmentLength;
+            else if (Segment == SegmentViewModelType.End)
+                segmentEnd = SelectedProfileElement.TimelineLength;
+
+            ShiftKeyframes(segmentEnd, null, amount);
         }
 
         private void WipeKeyframes(TimeSpan? start, TimeSpan? end)