Nodes - Improved changing pin types without reconnecting pins

UI - Fixed possible lingering UI elements in node editor and several other places

src/Artemis.Core/VisualScripting/Pin.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
+using System.Threading.Tasks;
 using Artemis.Core.Events;
 
 namespace Artemis.Core;
@@ -143,30 +144,20 @@ public abstract class Pin : CorePropertyChanged, IPin
     /// <param name="currentType">The backing field of the current type of the pin.</param>
     protected void ChangeType(Type type, ref Type currentType)
     {
-        // Enums are a special case that disconnect and, if still compatible, reconnect
+        if (currentType == type)
-        if (type.IsEnum && currentType.IsEnum)
+            return;
-        {
-            List<IPin> connections = new(ConnectedTo);
-            DisconnectAll();
 
-            // Change the type
+        bool changingEnums = type.IsEnum && currentType.IsEnum;
-            SetAndNotify(ref currentType, type, nameof(Type));
-            IsNumeric = type == typeof(Numeric);
 
-            foreach (IPin pin in connections.Where(p => p.IsTypeCompatible(type)))
+        List<IPin> connections = new(ConnectedTo);
-                ConnectTo(pin);
+        DisconnectAll();
-        }
-        // Disconnect pins incompatible with the new type
-        else
-        {
-            List<IPin> toDisconnect = ConnectedTo.Where(p => !p.IsTypeCompatible(type, false)).ToList();
-            foreach (IPin pin in toDisconnect)
-                DisconnectFrom(pin);
 
-            // Change the type
+        // Change the type
-            SetAndNotify(ref currentType, type, nameof(Type));
+        SetAndNotify(ref currentType, type, nameof(Type));
-            IsNumeric = type == typeof(Numeric);
+        IsNumeric = type == typeof(Numeric);
-        }
+
+        foreach (IPin pin in connections.Where(p => p.IsTypeCompatible(type, changingEnums)))
+            ConnectTo(pin);
     }
 
     #endregion

src/Artemis.UI/Screens/ProfileEditor/Panels/ProfileTree/Dialogs/LayerHintsDialogViewModel.cs

@@ -32,7 +32,7 @@ public class LayerHintsDialogViewModel : DialogViewModelBase<bool>
                 .Subscribe(c => AdaptionHints.Add(CreateHintViewModel(c.EventArgs.AdaptionHint)))
                 .DisposeWith(d);
             Observable.FromEventPattern<LayerAdapterHintEventArgs>(x => layer.Adapter.AdapterHintRemoved += x, x => layer.Adapter.AdapterHintRemoved -= x)
-                .Subscribe(c => AdaptionHints.Remove(AdaptionHints.FirstOrDefault(h => h.AdaptionHint == c.EventArgs.AdaptionHint)!))
+                .Subscribe(c => AdaptionHints.RemoveMany(AdaptionHints.Where(h => h.AdaptionHint == c.EventArgs.AdaptionHint)))
                 .DisposeWith(d);
 
             AdaptionHints.AddRange(Layer.Adapter.AdaptionHints.Select(CreateHintViewModel));

src/Artemis.UI/Screens/ProfileEditor/Panels/Properties/Timeline/TimelinePropertyViewModel.cs

@@ -42,7 +42,7 @@ public class TimelinePropertyViewModel<T> : ActivatableViewModelBase, ITimelineP
                 .Subscribe(e => _keyframes.Add((LayerPropertyKeyframe<T>) e.EventArgs.Keyframe))
                 .DisposeWith(d);
             Observable.FromEventPattern<LayerPropertyKeyframeEventArgs>(x => LayerProperty.KeyframeRemoved += x, x => LayerProperty.KeyframeRemoved -= x)
-                .Subscribe(e => _keyframes.Remove((LayerPropertyKeyframe<T>) e.EventArgs.Keyframe))
+                .Subscribe(e => _keyframes.RemoveMany(_keyframes.Items.Where(k => k == e.EventArgs.Keyframe)))
                 .DisposeWith(d);
 
             _keyframes.Edit(k =>

src/Artemis.UI/Screens/Sidebar/SidebarCategoryViewModel.cs

@@ -64,7 +64,7 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
                 .Subscribe(e => profileConfigurations.Add(e.EventArgs.ProfileConfiguration))
                 .DisposeWith(d);
             Observable.FromEventPattern<ProfileConfigurationEventArgs>(x => profileCategory.ProfileConfigurationRemoved += x, x => profileCategory.ProfileConfigurationRemoved -= x)
-                .Subscribe(e => profileConfigurations.Remove(e.EventArgs.ProfileConfiguration))
+                .Subscribe(e => profileConfigurations.RemoveMany(profileConfigurations.Items.Where(c => c == e.EventArgs.ProfileConfiguration)))
                 .DisposeWith(d);
 
             profileEditorService.ProfileConfiguration.Subscribe(p => SelectedProfileConfiguration = ProfileConfigurations.FirstOrDefault(c => ReferenceEquals(c.ProfileConfiguration, p)))

src/Artemis.UI/Screens/VisualScripting/NodeScriptViewModel.cs

@@ -50,10 +50,10 @@ public class NodeScriptViewModel : ActivatableViewModelBase
         this.WhenActivated(d =>
         {
             Observable.FromEventPattern<SingleValueEventArgs<INode>>(x => NodeScript.NodeAdded += x, x => NodeScript.NodeAdded -= x)
-                .Subscribe(e => HandleNodeAdded(e.EventArgs))
+                .Subscribe(e => _nodeViewModels.Add(_nodeVmFactory.NodeViewModel(this, e.EventArgs.Value)))
                 .DisposeWith(d);
             Observable.FromEventPattern<SingleValueEventArgs<INode>>(x => NodeScript.NodeRemoved += x, x => NodeScript.NodeRemoved -= x)
-                .Subscribe(e => HandleNodeRemoved(e.EventArgs))
+                .Subscribe(e => _nodeViewModels.RemoveMany(_nodeViewModels.Items.Where(n => n.Node == e.EventArgs.Value)))
                 .DisposeWith(d);
         });
 
@@ -276,16 +276,4 @@ public class NodeScriptViewModel : ActivatableViewModelBase
     private void ExecutePasteSelected()
     {
     }
-
-    private void HandleNodeAdded(SingleValueEventArgs<INode> eventArgs)
-    {
-        _nodeViewModels.Add(_nodeVmFactory.NodeViewModel(this, eventArgs.Value));
-    }
-
-    private void HandleNodeRemoved(SingleValueEventArgs<INode> eventArgs)
-    {
-        NodeViewModel? toRemove = NodeViewModels.FirstOrDefault(vm => ReferenceEquals(vm.Node, eventArgs.Value));
-        if (toRemove != null)
-            _nodeViewModels.Remove(toRemove);
-    }
 }

src/Artemis.UI/Screens/VisualScripting/NodeViewModel.cs

@@ -93,7 +93,7 @@ public class NodeViewModel : ActivatableViewModelBase
                 })
                 .DisposeWith(d);
             Observable.FromEventPattern<SingleValueEventArgs<IPin>>(x => Node.PinRemoved += x, x => Node.PinRemoved -= x)
-                .Subscribe(p => nodePins!.Remove(nodePins.Items.FirstOrDefault(vm => vm.Pin == p.EventArgs.Value)))
+                .Subscribe(p => nodePins.RemoveMany(nodePins.Items.Where(vm => vm.Pin == p.EventArgs.Value)))
                 .DisposeWith(d);
             nodePins.Edit(l =>
             {
@@ -118,7 +118,7 @@ public class NodeViewModel : ActivatableViewModelBase
                 })
                 .DisposeWith(d);
             Observable.FromEventPattern<SingleValueEventArgs<IPinCollection>>(x => Node.PinCollectionRemoved += x, x => Node.PinCollectionRemoved -= x)
-                .Subscribe(p => nodePinCollections!.Remove(nodePinCollections.Items.FirstOrDefault(vm => vm.PinCollection == p.EventArgs.Value)))
+                .Subscribe(p => nodePinCollections.RemoveMany(nodePinCollections.Items.Where(vm => vm.PinCollection == p.EventArgs.Value)))
                 .DisposeWith(d);
             nodePinCollections.Edit(l =>
             {
@@ -161,7 +161,7 @@ public class NodeViewModel : ActivatableViewModelBase
         set => RaiseAndSetIfChanged(ref _isSelected, value);
     }
 
-    public ReactiveCommand<Unit,Unit> ShowBrokenState { get; }
+    public ReactiveCommand<Unit, Unit> ShowBrokenState { get; }
     public ReactiveCommand<Unit, Unit> DeleteNode { get; }
 
     public void StartDrag(Point mouseStartPosition)

src/Artemis.UI/Screens/VisualScripting/Pins/PinCollectionViewModel.cs

@@ -30,7 +30,7 @@ public abstract class PinCollectionViewModel : ActivatableViewModelBase
                 .Subscribe(e => PinViewModels.Add(CreatePinViewModel(e.EventArgs.Value)))
                 .DisposeWith(d);
             Observable.FromEventPattern<SingleValueEventArgs<IPin>>(x => PinCollection.PinRemoved += x, x => PinCollection.PinRemoved -= x)
-                .Subscribe(e => PinViewModels.RemoveMany(PinViewModels.Where(p => p.Pin == e.EventArgs.Value).ToList()))
+                .Subscribe(e => PinViewModels.RemoveMany(PinViewModels.Where(p => p.Pin == e.EventArgs.Value)))
                 .DisposeWith(d);
         });
 

src/Artemis.UI/Screens/VisualScripting/Pins/PinViewModel.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 using System.Reactive;
 using System.Reactive.Linq;
 using Artemis.Core;
@@ -38,7 +39,7 @@ public abstract class PinViewModel : ActivatableViewModelBase
                 .Subscribe(e => connectedPins.Add(e.EventArgs.Value))
                 .DisposeWith(d);
             Observable.FromEventPattern<SingleValueEventArgs<IPin>>(x => Pin.PinDisconnected += x, x => Pin.PinDisconnected -= x)
-                .Subscribe(e => connectedPins.Remove(e.EventArgs.Value))
+                .Subscribe(e => connectedPins.RemoveMany(connectedPins.Items.Where(p => p == e.EventArgs.Value)))
                 .DisposeWith(d);
             Pin.WhenAnyValue(p => p.Type).Subscribe(_ => UpdatePinColor()).DisposeWith(d);
         });