Software rendering - Fixed memory leak

Rendering - Swap back and forth between software and GPU without crash

src/Artemis.Core/Models/Profile/Renderer.cs

@@ -9,6 +9,7 @@ namespace Artemis.Core
         private bool _disposed;
         private SKRect _lastBounds;
         private SKRect _lastParentBounds;
+        private GRContext? _lastGraphicsContext;
         public SKSurface? Surface { get; private set; }
         public SKPaint? Paint { get; private set; }
         public SKPath? Path { get; private set; }
@@ -27,7 +28,7 @@ namespace Artemis.Core
             if (IsOpen)
                 throw new ArtemisCoreException("Cannot open render context because it is already open");
 
-            if (path.Bounds != _lastBounds || (parent != null && parent.Bounds != _lastParentBounds))
+            if (path.Bounds != _lastBounds || (parent != null && parent.Bounds != _lastParentBounds) || _lastGraphicsContext != Constants.ManagedGraphicsContext?.GraphicsContext)
                 Invalidate();
 
             if (!_valid || Surface == null)
@@ -41,7 +42,7 @@ namespace Artemis.Core
                     Surface = SKSurface.Create(imageInfo);
                 else
                     Surface = SKSurface.Create(Constants.ManagedGraphicsContext.GraphicsContext, true, imageInfo);
-                
+
                 Path = new SKPath(path);
                 Path.Transform(SKMatrix.CreateTranslation(pathBounds.Left * -1, pathBounds.Top * -1));
 
@@ -53,6 +54,7 @@ namespace Artemis.Core
 
                 _lastParentBounds = parent?.Bounds ?? new SKRect();
                 _lastBounds = path.Bounds;
+                _lastGraphicsContext = Constants.ManagedGraphicsContext?.GraphicsContext;
                 _valid = true;
             }
 
@@ -70,7 +72,14 @@ namespace Artemis.Core
                 throw new ObjectDisposedException("Renderer");
 
             Surface?.Canvas.Restore();
+
+            // Looks like every part of the paint needs to be disposed :(
+            Paint?.ColorFilter?.Dispose();
+            Paint?.ImageFilter?.Dispose();
+            Paint?.MaskFilter?.Dispose();
+            Paint?.PathEffect?.Dispose();
             Paint?.Dispose();
+
             Paint = null;
 
             IsOpen = false;

src/Artemis.Core/Services/RgbService.cs

@@ -51,6 +51,8 @@ namespace Artemis.Core.Services
 
             UpdateTrigger = new TimerUpdateTrigger {UpdateFrequency = 1.0 / _targetFrameRateSetting.Value};
             Surface.RegisterUpdateTrigger(UpdateTrigger);
+
+            Utilities.ShutdownRequested += UtilitiesOnShutdownRequested;
         }
 
         public TimerUpdateTrigger UpdateTrigger { get; }
@@ -66,6 +68,11 @@ namespace Artemis.Core.Services
             _texture?.Invalidate();
         }
 
+        private void UtilitiesOnShutdownRequested(object? sender, EventArgs e)
+        {
+            IsRenderPaused = true;
+        }
+
         private void SurfaceOnLayoutChanged(SurfaceLayoutChangedEventArgs args)
         {
             UpdateLedGroup();
@@ -115,6 +122,11 @@ namespace Artemis.Core.Services
             DeviceAdded?.Invoke(this, e);
         }
 
+        private void RenderScaleSettingOnSettingChanged(object? sender, EventArgs e)
+        {
+            _texture?.Invalidate();
+        }
+
         public IReadOnlyCollection<ArtemisDevice> EnabledDevices => _enabledDevices.AsReadOnly();
         public IReadOnlyCollection<ArtemisDevice> Devices => _devices.AsReadOnly();
         public IReadOnlyDictionary<Led, ArtemisLed> LedMap => new ReadOnlyDictionary<Led, ArtemisLed>(_ledMap);
@@ -195,11 +207,6 @@ namespace Artemis.Core.Services
             }
         }
 
-        private void RenderScaleSettingOnSettingChanged(object? sender, EventArgs e)
-        {
-            _texture?.Invalidate();
-        }
-
         public void Dispose()
         {
             Surface.UnregisterUpdateTrigger(UpdateTrigger);
@@ -245,7 +252,7 @@ namespace Artemis.Core.Services
             IManagedGraphicsContext? graphicsContext = Constants.ManagedGraphicsContext = _newGraphicsContext;
             if (!ReferenceEquals(graphicsContext, _newGraphicsContext))
                 graphicsContext = _newGraphicsContext;
-            
+
             if (graphicsContext != null)
                 _logger.Debug("Creating SKTexture with graphics context {graphicsContext}", graphicsContext.GetType().Name);
             else