From acd2a726781cae3219685ca35930cc1c0bbeae8a Mon Sep 17 00:00:00 2001
From: Robert <mail@rbeekman.nl>
Date: Tue, 8 Dec 2020 19:51:31 +0100
Subject: [PATCH] Surface editor - Tweaked device dialog

---
 .../Dialogs/SurfaceDeviceConfigView.xaml      | 178 ++++++++++--------
 .../Dialogs/SurfaceDeviceConfigViewModel.cs   |   9 -
 2 files changed, 103 insertions(+), 84 deletions(-)

diff --git a/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigView.xaml b/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigView.xaml
index f19f2c753..c11e806d3 100644
--- a/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigView.xaml
+++ b/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigView.xaml
@@ -12,102 +12,131 @@
     <UserControl.Resources>
         <shared:SKColorToColorConverter x:Key="SKColorToColorConverter" />
     </UserControl.Resources>
-    <StackPanel Margin="16">
-        <TextBlock Text="{Binding Title}"
-                   Style="{StaticResource MaterialDesignHeadline6TextBlock}" />
-        <TextBlock Text="Note: These are not being validated yet"
-                   Style="{StaticResource MaterialDesignSubtitle1TextBlock}" />
+    <StackPanel Margin="16" Width="400">
+        <!-- Title -->
+        <TextBlock Text="{Binding Device.RgbDevice.DeviceInfo.DeviceName}" Style="{StaticResource MaterialDesignHeadline6TextBlock}" />
+        
+        <!-- Body -->
+        <Grid Margin="0 25 0 0">
+            <Grid.ColumnDefinitions>
+                <ColumnDefinition Width="2*" />
+                <ColumnDefinition Width="40" />
+                <ColumnDefinition Width="3*" />
+            </Grid.ColumnDefinitions>
+
+            <!-- Left side -->
+            <StackPanel Grid.Column="0" Orientation="Vertical">
+                <TextBlock Style="{StaticResource MaterialDesignSubtitle1TextBlock}">
+                    Properties
+                </TextBlock>
 
-        <StackPanel Orientation="Horizontal">
-            <StackPanel Orientation="Vertical"
-                        Width="150"
-                        Margin="8">
                 <TextBox materialDesign:HintAssist.Hint="X-coordinate"
                          materialDesign:TextFieldAssist.SuffixText="mm"
                          Text="{Binding X, UpdateSourceTrigger=PropertyChanged}"
                          Style="{StaticResource MaterialDesignFloatingHintTextBox}"
-                         Margin="0 10" />
+                         Margin="0 5" />
                 <TextBox materialDesign:HintAssist.Hint="Y-coordinate"
                          materialDesign:TextFieldAssist.SuffixText="mm"
                          Text="{Binding Y, UpdateSourceTrigger=PropertyChanged}"
                          Style="{StaticResource MaterialDesignFloatingHintTextBox}"
-                         Margin="0 10" />
+                         Margin="0 5" />
                 <TextBox materialDesign:HintAssist.Hint="Scale"
                          materialDesign:TextFieldAssist.SuffixText="times"
                          Text="{Binding Scale, UpdateSourceTrigger=PropertyChanged}"
                          Style="{StaticResource MaterialDesignFloatingHintTextBox}"
-                         Margin="0 10" />
+                         Margin="0 5" />
                 <TextBox materialDesign:HintAssist.Hint="Rotation"
                          materialDesign:TextFieldAssist.SuffixText="deg"
                          Text="{Binding Rotation, UpdateSourceTrigger=PropertyChanged}"
                          Style="{StaticResource MaterialDesignFloatingHintTextBox}"
-                         Margin="0 10" />
+                         Margin="0 5 0 12" />
             </StackPanel>
-            <StackPanel Orientation="Vertical"
-                        Width="250"
-                        Margin="8">
-                <Grid>
+
+            <!-- Center divider -->
+            <Rectangle Grid.Column="1" VerticalAlignment="Stretch" Fill="{StaticResource MaterialDesignTextBoxBorder}" Width="1" Margin="0 0 0 5" />
+
+            <!-- Right side -->
+            <Grid Grid.Column="2">
+                <Grid.ColumnDefinitions>
+                    <ColumnDefinition Width="Auto" />
+                    <ColumnDefinition Width="*" />
+                    <ColumnDefinition Width="Auto" />
+                </Grid.ColumnDefinitions>
+                <Grid.RowDefinitions>
+                    <RowDefinition Height="Auto" />
+                    <RowDefinition />
+                    <RowDefinition />
+                    <RowDefinition />
+                    <RowDefinition />
+                    <RowDefinition Height="*" />
+                </Grid.RowDefinitions>
+
+                <TextBlock Grid.Row="0" Grid.ColumnSpan="3" Style="{StaticResource MaterialDesignSubtitle1TextBlock}">
+                    Color calibration
+                </TextBlock>
+
+                <TextBlock Grid.Row="1" 
+                           Grid.Column="0"
+                           Grid.ColumnSpan="3"
+                           Style="{StaticResource MaterialDesignCaptionTextBlock}" 
+                           Foreground="{DynamicResource MaterialDesignBodyLight}"
+                           TextWrapping="Wrap" 
+                           TextAlignment="Justify">
+                    Use the sliders below to adjust the colors of your device so that it matches your other devices.
+                </TextBlock>
+
+                <Label Grid.Row="2" Grid.Column="0" Content="R-" VerticalAlignment="Center" />
+                <Slider Grid.Row="2"
+                        Grid.Column="1"
+                        Minimum="0"
+                        Maximum="200"
+                        ValueChanged="{s:Action ApplyScaling}"
+                        Value="{Binding RedScale, UpdateSourceTrigger=PropertyChanged}"
+                        Margin="10 0"
+                        VerticalAlignment="Center" />
+                <Label Grid.Row="2" Grid.Column="2" Content="R+" VerticalAlignment="Center" />
+
+                <Label Grid.Row="3" Grid.Column="0" Content="G-" VerticalAlignment="Center" />
+                <Slider Grid.Row="3"
+                        Grid.Column="1"
+                        Minimum="0"
+                        Maximum="200"
+                        ValueChanged="{s:Action ApplyScaling}"
+                        Value="{Binding GreenScale, UpdateSourceTrigger=PropertyChanged}"
+                        Margin="10 0"
+                        VerticalAlignment="Center" />
+                <Label Grid.Row="3" Grid.Column="2" Content="G+" VerticalAlignment="Center" />
+
+                <Label Grid.Row="4" Grid.Column="0" Content="B-" VerticalAlignment="Center" />
+                <Slider Grid.Row="4"
+                        Grid.Column="1"
+                        Minimum="0"
+                        Maximum="200"
+                        ValueChanged="{s:Action ApplyScaling}"
+                        Value="{Binding BlueScale, UpdateSourceTrigger=PropertyChanged}"
+                        Margin="10 0"
+                        VerticalAlignment="Center" />
+                <Label Grid.Row="4" Grid.Column="2" Content="B+" VerticalAlignment="Center" />
+
+                <Grid Grid.Row="5" Grid.Column="0" Grid.ColumnSpan="3">
                     <Grid.ColumnDefinitions>
-                        <ColumnDefinition Width="Auto"
-                                          MinWidth="41" />
-                        <ColumnDefinition Width="Auto"
-                                          MinWidth="184.937" />
+                        <ColumnDefinition />
+                        <ColumnDefinition />
                     </Grid.ColumnDefinitions>
-                    <Grid.RowDefinitions>
-                        <RowDefinition Height="Auto" />
-                        <RowDefinition Height="Auto" />
-                        <RowDefinition Height="Auto" />
-                    </Grid.RowDefinitions>
-
-                    <Label Grid.Column="0"
-                           Grid.Row="0"
-                           Content="Red"
-                           VerticalAlignment="Bottom" />
-                    <Slider Grid.Column="1"
-                            Grid.Row="0"
-                            Minimum="0"
-                            Maximum="200"
-                            ValueChanged="{s:Action ApplyScaling}"
-                            Value="{Binding RedScale, UpdateSourceTrigger=PropertyChanged}"
-                            Style="{StaticResource MaterialDesignDiscreteSlider}" />
-
-                    <Label Grid.Column="0"
-                           Grid.Row="1"
-                           Content="Green"
-                           VerticalAlignment="Bottom" />
-                    <Slider Grid.Column="1"
-                            Grid.Row="1"
-                            Minimum="0"
-                            Maximum="200"
-                            ValueChanged="{s:Action ApplyScaling}"
-                            Value="{Binding GreenScale, UpdateSourceTrigger=PropertyChanged}"
-                            Style="{StaticResource MaterialDesignDiscreteSlider}" />
-
-                    <Label Grid.Column="0"
-                           Grid.Row="2"
-                           Content="Blue"
-                           VerticalAlignment="Bottom" />
-                    <Slider Grid.Column="1"
-                            Grid.Row="2"
-                            Minimum="0"
-                            Maximum="200"
-                            ValueChanged="{s:Action ApplyScaling}"
-                            Value="{Binding BlueScale, UpdateSourceTrigger=PropertyChanged}"
-                            Style="{StaticResource MaterialDesignDiscreteSlider}" />
-                </Grid>
-                <DockPanel>
-                    <CheckBox IsChecked="{Binding DisplayOnDevices}"
-                              Margin="5,0,0,0"
-                              Content="Display on Devices"
-                              HorizontalAlignment="Left" />
-                    <shared:ColorPicker Margin="0,0,5,0"
+                    <CheckBox Grid.Column="0"
+                              IsChecked="{Binding DisplayOnDevices}"
+                              Content="Show preview"
+                              VerticalAlignment="Center" />
+                    <shared:ColorPicker Grid.Column="1"
+                                        Margin="0,0,5,0"
                                         HorizontalAlignment="Right"
-                                        Color="{Binding CurrentColor, Converter={StaticResource SKColorToColorConverter}}" />
-                </DockPanel>
-
-            </StackPanel>
-        </StackPanel>
+                                        Color="{Binding CurrentColor, Converter={StaticResource SKColorToColorConverter}}" 
+                                        VerticalAlignment="Center"/>
+                </Grid>
+            </Grid>
+        </Grid>
 
+        <!-- Buttons -->
         <StackPanel Orientation="Horizontal"
                     HorizontalAlignment="Right">
             <Button Style="{StaticResource MaterialDesignFlatButton}"
@@ -133,6 +162,5 @@
                 APPLY
             </Button>
         </StackPanel>
-
     </StackPanel>
 </UserControl>
\ No newline at end of file
diff --git a/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigViewModel.cs b/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigViewModel.cs
index efc5be348..0b96110f8 100644
--- a/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigViewModel.cs
+++ b/src/Artemis.UI/Screens/SurfaceEditor/Dialogs/SurfaceDeviceConfigViewModel.cs
@@ -12,7 +12,6 @@ namespace Artemis.UI.Screens.SurfaceEditor.Dialogs
         private readonly ICoreService _coreService;
         private int _rotation;
         private double _scale;
-        private string _title;
         private int _x;
         private int _y;
         public double _redScale;
@@ -26,7 +25,6 @@ namespace Artemis.UI.Screens.SurfaceEditor.Dialogs
             _coreService = coreService;
 
             Device = device;
-            Title = $"{Device.RgbDevice.DeviceInfo.DeviceName} - Properties";
 
             X = (int)Device.X;
             Y = (int)Device.Y;
@@ -53,13 +51,6 @@ namespace Artemis.UI.Screens.SurfaceEditor.Dialogs
 
         public ArtemisDevice Device { get; }
 
-
-        public string Title
-        {
-            get => _title;
-            set => SetAndNotify(ref _title, value);
-        }
-
         public int X
         {
             get => _x;