Plugin info - Implemented property changed

Plugins - Improved enable failure detection
Plugins UI - Show an indicator on plugins that failed to enable
Plugins UI - Show a progress indicator on plugins that are enabling
UI - Added reusable Snackbar (not the Dutch kind with kroketten)

src/Artemis.UI/Screens/Settings/SettingsViewModel.cs

@@ -27,20 +27,20 @@ namespace Artemis.UI.Screens.Settings
         private readonly IDialogService _dialogService;
         private readonly IPluginService _pluginService;
         private readonly ISettingsService _settingsService;
+        private readonly IPluginSettingsVmFactory _pluginSettingsVmFactory;
         private readonly ISurfaceService _surfaceService;
-        private readonly IWindowManager _windowManager;
 
-        public SettingsViewModel(ISurfaceService surfaceService, IPluginService pluginService, IDialogService dialogService, IWindowManager windowManager,
-            IDebugService debugService, ISettingsService settingsService, IDeviceSettingsVmFactory deviceSettingsVmFactory)
+        public SettingsViewModel(ISurfaceService surfaceService, IPluginService pluginService, IDialogService dialogService, IDebugService debugService,
+            ISettingsService settingsService, IPluginSettingsVmFactory pluginSettingsVmFactory, IDeviceSettingsVmFactory deviceSettingsVmFactory)
         {
             DisplayName = "Settings";
 
             _surfaceService = surfaceService;
             _pluginService = pluginService;
             _dialogService = dialogService;
-            _windowManager = windowManager;
             _debugService = debugService;
             _settingsService = settingsService;
+            _pluginSettingsVmFactory = pluginSettingsVmFactory;
             _deviceSettingsVmFactory = deviceSettingsVmFactory;
 
             DeviceSettingsViewModels = new BindableCollection<DeviceSettingsViewModel>();
@@ -189,7 +189,7 @@ namespace Artemis.UI.Screens.Settings
             DeviceSettingsViewModels.AddRange(_surfaceService.ActiveSurface.Devices.Select(d => _deviceSettingsVmFactory.Create(d)));
 
             Plugins.Clear();
-            Plugins.AddRange(_pluginService.GetAllPluginInfo().Select(p => new PluginSettingsViewModel(p.Instance, _windowManager, _dialogService, _pluginService)));
+            Plugins.AddRange(_pluginService.GetAllPluginInfo().Select(p => _pluginSettingsVmFactory.Create(p.Instance)));
 
             base.OnInitialActivate();
         }

src/Artemis.UI/Screens/Settings/Tabs/Plugins/PluginSettingsView.xaml

@@ -36,6 +36,7 @@
                 <Grid.ColumnDefinitions>
                     <ColumnDefinition Width="80" />
                     <ColumnDefinition Width="*" />
+                    <ColumnDefinition Width="Auto"/>
                 </Grid.ColumnDefinitions>
                 <Grid.RowDefinitions>
                     <RowDefinition Height="Auto" />
@@ -43,9 +44,16 @@
                 </Grid.RowDefinitions>
 
                 <materialDesign:PackIcon Kind="{Binding Icon}" Width="48" Height="48" Grid.Row="0" Grid.RowSpan="2" HorizontalAlignment="Center" />
-                <TextBlock Style="{StaticResource MaterialDesignTextBlock}" Text="{Binding PluginInfo.Name}" Grid.Column="1" Grid.Row="0" />
+
+                <TextBlock Grid.Column="1" Grid.Row="0" Style="{StaticResource MaterialDesignTextBlock}" Text="{Binding PluginInfo.Name}"  />
+                <materialDesign:Card Grid.Column="2" Grid.Row="0" Background="#FF4343" Height="22" Padding="4" Margin="0 -18 0 0"
+                                     Visibility="{Binding PluginInfo.LastEnableSuccessful, Converter={x:Static s:BoolToVisibilityConverter.InverseInstance}, Mode=OneWay}">
+                    LOAD FAILED
+                </materialDesign:Card>
+
                 <TextBlock Grid.Column="1"
                            Grid.Row="1"
+                           Grid.ColumnSpan="2"
                            TextWrapping="Wrap"
                            Text="{Binding PluginInfo.Description}"
                            Style="{StaticResource MaterialDesignTextBlock}"
@@ -56,15 +64,17 @@
                 <Button Style="{StaticResource MaterialDesignOutlinedButton}" ToolTip="MaterialDesignOutlinedButton" Margin="4" s:View.ActionTarget="{Binding}" Command="{s:Action OpenSettings}">
                     SETTINGS
                 </Button>
-                <!-- <Button Style="{StaticResource MaterialDesignOutlinedButton}" ToolTip="MaterialDesignOutlinedButton" Margin="4"> -->
-                <!--     SETTINGS -->
-                <!-- </Button> -->
             </StackPanel>
-            <StackPanel Grid.Row="1" Grid.Column="1" HorizontalAlignment="Right" VerticalAlignment="Center" Margin="8">
+            <StackPanel Grid.Row="1" Grid.Column="1" HorizontalAlignment="Right" VerticalAlignment="Center" Margin="8"
+                        Visibility="{Binding Enabling, Converter={x:Static s:BoolToVisibilityConverter.InverseInstance}, Mode=OneWay}">
                 <CheckBox Style="{StaticResource MaterialDesignCheckBox}" IsChecked="{Binding IsEnabled}">
                     Plugin enabled
                 </CheckBox>
             </StackPanel>
+            <StackPanel Grid.Row="1" Grid.Column="1" HorizontalAlignment="Right" VerticalAlignment="Center" Margin="8"
+                        Visibility="{Binding Enabling, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}">
+                <ProgressBar Style="{StaticResource MaterialDesignCircularProgressBar}" Value="0" IsIndeterminate="True" />
+            </StackPanel>
         </Grid>
     </materialDesign:Card>
 </UserControl>

src/Artemis.UI/Screens/Settings/Tabs/Plugins/PluginSettingsViewModel.cs

@@ -1,4 +1,6 @@
 using System;
+using System.Diagnostics;
+using System.IO;
 using System.Threading.Tasks;
 using Artemis.Core.Plugins.Abstract;
 using Artemis.Core.Plugins.Models;
@@ -13,9 +15,11 @@ namespace Artemis.UI.Screens.Settings.Tabs.Plugins
     {
         private readonly IDialogService _dialogService;
         private readonly IPluginService _pluginService;
+        private readonly ISnackbarMessageQueue _snackbarMessageQueue;
         private readonly IWindowManager _windowManager;
 
-        public PluginSettingsViewModel(Plugin plugin, IWindowManager windowManager, IDialogService dialogService, IPluginService pluginService)
+        public PluginSettingsViewModel(Plugin plugin, IWindowManager windowManager, IDialogService dialogService, IPluginService pluginService,
+            ISnackbarMessageQueue snackbarMessageQueue)
         {
             Plugin = plugin;
             PluginInfo = plugin.PluginInfo;
@@ -23,6 +27,7 @@ namespace Artemis.UI.Screens.Settings.Tabs.Plugins
             _windowManager = windowManager;
             _dialogService = dialogService;
             _pluginService = pluginService;
+            _snackbarMessageQueue = snackbarMessageQueue;
         }
 
         public Plugin Plugin { get; set; }
@@ -40,6 +45,8 @@ namespace Artemis.UI.Screens.Settings.Tabs.Plugins
 
         public bool CanOpenSettings => IsEnabled && Plugin.HasConfigurationViewModel;
 
+        public bool Enabling { get; set; }
+
         public async Task OpenSettings()
         {
             try
@@ -55,6 +62,18 @@ namespace Artemis.UI.Screens.Settings.Tabs.Plugins
             }
         }
 
+        public async Task ShowLogsFolder()
+        {
+            try
+            {
+                Process.Start(Environment.GetEnvironmentVariable("WINDIR") + @"\explorer.exe", Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Logs"));
+            }
+            catch (Exception e)
+            {
+                await _dialogService.ShowExceptionDialog("Welp, we couldn\'t open the logs folder for you", e);
+            }
+        }
+
         private PackIconKind GetIconKind()
         {
             if (PluginInfo.Icon != null)
@@ -105,7 +124,23 @@ namespace Artemis.UI.Screens.Settings.Tabs.Plugins
             }
 
             if (enable)
-                _pluginService.EnablePlugin(Plugin);
+            {
+                Enabling = true;
+                try
+                {
+                    _pluginService.EnablePlugin(Plugin);
+                    _snackbarMessageQueue.Enqueue($"Enabled plugin {PluginInfo.Name}");
+                }
+                catch (Exception)
+                {
+                    _snackbarMessageQueue.Enqueue($"Failed to enable plugin {PluginInfo.Name}", "VIEW LOGS", async () => await ShowLogsFolder());
+                }
+                finally
+                {
+                    Enabling = false;
+                    NotifyOfPropertyChange(() => IsEnabled);
+                }
+            }
             else
                 _pluginService.DisablePlugin(Plugin);