DarthAffe/Artemis
1
0
Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2025-12-13 05:48:35 +00:00
Code Issues Releases Wiki Activity

Plugins - Ignore version when loading shared assemblies

Browse Source 
Sidebar - Improved category reordering code
This commit is contained in:
Robert 2022-10-14 17:23:36 +02:00
parent 937fe1fb74
commit 9c4bc3d9c6
2 changed files with 34 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Artemis.Core/Services/PluginManagementService.cs
View File

@ -5,6 +5,7 @@ using System.IO;
using System.IO.Compression;
using System.Linq;
using System.Reflection;
using System.Runtime.Loader;
using System.Threading.Tasks;
using Artemis.Core.DeviceProviders;
using Artemis.Core.Ninject;
@ -334,11 +335,14 @@ internal class PluginManagementService : IPluginManagementService
throw new ArtemisPluginException(plugin, "Plugin main entry casing mismatch at " + plugin.Info.Main);
// Load the plugin, all types implementing Plugin and register them with DI
plugin.PluginLoader = PluginLoader.CreateFromAssemblyFile(mainFile!, configure =>
plugin.PluginLoader = PluginLoader.CreateFromAssemblyFile(mainFile, configure =>
{
configure.IsUnloadable = true;
configure.LoadInMemory = true;
configure.PreferSharedTypes = true;
// Resolving failed, try a loaded assembly but ignoring the version
configure.DefaultContext.Resolving += (context, assemblyName) => context.Assemblies.FirstOrDefault(a => a.GetName().Name == assemblyName.Name);
});
try

31
src/Artemis.UI/Screens/Sidebar/SidebarCategoryViewModel.cs
View File

@ -26,6 +26,7 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
private readonly IProfileService _profileService;
private readonly ISidebarVmFactory _vmFactory;
private readonly IWindowService _windowService;
private readonly IProfileEditorService _profileEditorService;
private ObservableAsPropertyHelper<bool>? _isCollapsed;
private ObservableAsPropertyHelper<bool>? _isSuspended;
private SidebarProfileConfigurationViewModel? _selectedProfileConfiguration;
@ -38,6 +39,7 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
{
_profileService = profileService;
_windowService = windowService;
_profileEditorService = profileEditorService;
_vmFactory = vmFactory;
ProfileCategory = profileCategory;
@ -154,7 +156,11 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
private async Task ExecuteDeleteCategory()
{
if (await _windowService.ShowConfirmContentDialog($"Delete {ProfileCategory.Name}", "Do you want to delete this category and all its profiles?"))
{
if (ProfileCategory.ProfileConfigurations.Any(c => c.IsBeingEdited))
_profileEditorService.ChangeCurrentProfileConfiguration(null);
_profileService.DeleteProfileCategory(ProfileCategory);
}
}
private async Task ExecuteAddProfile()
@ -225,10 +231,9 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
if (index <= 0)
return;
categories[index - 1].Order++;
ProfileCategory.Order--;
_profileService.SaveProfileCategory(categories[index - 1]);
_profileService.SaveProfileCategory(ProfileCategory);
categories.Remove(ProfileCategory);
categories.Insert(index - 1, ProfileCategory);
ApplyCategoryOrder(categories);
}
private void ExecuteMoveDown()
@ -238,9 +243,19 @@ public class SidebarCategoryViewModel : ActivatableViewModelBase
if (index >= categories.Count - 1)
return;
categories[index + 1].Order--;
ProfileCategory.Order++;
_profileService.SaveProfileCategory(categories[index + 1]);
_profileService.SaveProfileCategory(ProfileCategory);
categories.Remove(ProfileCategory);
categories.Insert(index + 1, ProfileCategory);
ApplyCategoryOrder(categories);
}
private void ApplyCategoryOrder(List<ProfileCategory> categories)
{
for (int i = 0; i < categories.Count; i++)
{
if (categories[i].Order == i + 1)
continue;
categories[i].Order = i + 1;
_profileService.SaveProfileCategory(categories[i]);
}
}
}