DarthAffe/Artemis
1
0 Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2026-11-12 03:48:56 +00:00
Code Issues Releases Wiki Activity

UI - Improved exception dialog shown at early startup failure

Browse Source 
Plugins - Provide a better error message on built in plugin installation failure
Conditions - Added better null/not null checks for strings
This commit is contained in:
Robert committed 2021-04-10 19:32:21 +02:00
1 parent c66c21152f
commit 992657b0c5
6 files changed
+94 -11
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Artemis.Core/Services/PluginManagementService.cs
+10 -2
View File
@@ -98,11 +98,19 @@ namespace Artemis.Core.Services
}
else
{
PluginInfo pluginInfo;
try
{
// Compare versions, copy if the same when debugging
PluginInfo pluginInfo = CoreJson.DeserializeObject<PluginInfo>(File.ReadAllText(metadataFile))!;
pluginInfo = CoreJson.DeserializeObject<PluginInfo>(File.ReadAllText(metadataFile))!;
}
catch (Exception e)
{
throw new ArtemisPluginException($"Failed read plugin metadata needed to install built-in plugin: {e.Message}", e);
}
try
{
if (builtInPluginInfo.Version > pluginInfo.Version)
{
_logger.Debug("Copying updated built-in plugin from {pluginInfo} to {builtInPluginInfo}", pluginInfo, builtInPluginInfo);
@@ -111,7 +119,7 @@ namespace Artemis.Core.Services
}
catch (Exception e)
{
throw new ArtemisPluginException("Failed read plugin metadata needed to install built-in plugin", e);
throw new ArtemisPluginException($"Failed to install built-in plugin: {e.Message}", e);
}
}
}
src/Artemis.Core/Services/Registration/ConditionOperatorService.cs
+2
View File
@@ -61,6 +61,8 @@ namespace Artemis.Core.Services
RegisterConditionOperator(Constants.CorePlugin, new StringStartsWithConditionOperator());
RegisterConditionOperator(Constants.CorePlugin, new StringEndsWithConditionOperator());
RegisterConditionOperator(Constants.CorePlugin, new StringMatchesRegexConditionOperator());
RegisterConditionOperator(Constants.CorePlugin, new StringNullConditionOperator());
RegisterConditionOperator(Constants.CorePlugin, new StringNotNullConditionOperator());
// Null checks, at the bottom
// TODO: Implement a priority mechanism