Data bindings - Highlight current property

Data bindings - Disable data-bound property inputs
Data bindings - Use toggle to indicate data bindings being enabled

src/Artemis.UI/Screens/ProfileEditor/LayerProperties/Tree/TreePropertyView.xaml

@@ -5,6 +5,7 @@
              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
              xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
              xmlns:s="https://github.com/canton7/Stylet"
+             xmlns:shared="clr-namespace:Artemis.UI.Shared;assembly=Artemis.UI.Shared"
              mc:Ignorable="d"
              d:DesignHeight="450" d:DesignWidth="800">
     <Grid Height="22" Margin="-20 0 0 0">
@@ -43,15 +44,17 @@
             </ContentControl.Resources>
         </ContentControl>
 
-        <ToggleButton Grid.Column="3"
-                      Style="{StaticResource MaterialDesignFlatPrimaryToggleButton}"
+        <shared:LockableToggleButton Grid.Column="3"
+                      Style="{StaticResource MaterialDesignFlatToggleButton}"
                       ToolTip="Change the property's data binding"
                       Width="20"
                       Height="20"
                       VerticalAlignment="Center"
+                      IsLocked="True"
                       IsEnabled="{Binding LayerProperty.DataBindingsSupported}"
-                      IsChecked="{Binding DataBindingsOpen}">
+                      IsChecked="{Binding HasDataBinding, Mode=OneWay}"
+                      Click="{s:Action ActivateDataBindingViewModel}">
             <materialDesign:PackIcon Kind="VectorLink" Height="13" Width="13" />
-        </ToggleButton>
+        </shared:LockableToggleButton>
     </Grid>
 </UserControl>

src/Artemis.UI/Screens/ProfileEditor/LayerProperties/Tree/TreePropertyViewModel.cs

@@ -22,10 +22,11 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
             PropertyInputViewModel = _profileEditorService.CreatePropertyInputViewModel(LayerProperty);
             _profileEditorService.SelectedDataBindingChanged += ProfileEditorServiceOnSelectedDataBindingChanged;
             LayerProperty.VisibilityChanged += LayerPropertyOnVisibilityChanged;
-
+            LayerProperty.DataBindingEnabled += LayerPropertyOnDataBindingChange;
+            LayerProperty.DataBindingDisabled += LayerPropertyOnDataBindingChange;
             LayerPropertyViewModel.IsVisible = !LayerProperty.IsHidden;
         }
-
+        
         public LayerProperty<T> LayerProperty { get; }
         public LayerPropertyViewModel LayerPropertyViewModel { get; }
 
@@ -35,6 +36,8 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
             set => SetAndNotify(ref _propertyInputViewModel, value);
         }
 
+        public bool HasDataBinding => LayerProperty.HasDataBinding;
+
         public bool HasPropertyInputViewModel => PropertyInputViewModel != null;
 
         public bool KeyframesEnabled
@@ -43,10 +46,12 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
             set => ApplyKeyframesEnabled(value);
         }
 
-        public bool DataBindingsOpen
+        public void ActivateDataBindingViewModel()
         {
-            get => _profileEditorService.SelectedDataBinding == LayerProperty;
-            set => _profileEditorService.ChangeSelectedDataBinding(value ? LayerProperty : null);
+            if (_profileEditorService.SelectedDataBinding == LayerProperty)
+                _profileEditorService.ChangeSelectedDataBinding(null);
+            else
+                _profileEditorService.ChangeSelectedDataBinding(LayerProperty);
         }
 
         #region IDisposable
@@ -56,6 +61,8 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
             _propertyInputViewModel?.Dispose();
             _profileEditorService.SelectedDataBindingChanged -= ProfileEditorServiceOnSelectedDataBindingChanged;
             LayerProperty.VisibilityChanged -= LayerPropertyOnVisibilityChanged;
+            LayerProperty.DataBindingEnabled -= LayerPropertyOnDataBindingChange;
+            LayerProperty.DataBindingDisabled -= LayerPropertyOnDataBindingChange;
         }
 
         #endregion
@@ -85,7 +92,7 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
 
         private void ProfileEditorServiceOnSelectedDataBindingChanged(object sender, EventArgs e)
         {
-            NotifyOfPropertyChange(nameof(DataBindingsOpen));
+            LayerPropertyViewModel.IsHighlighted = _profileEditorService.SelectedDataBinding == LayerProperty;
         }
 
         private void LayerPropertyOnVisibilityChanged(object? sender, LayerPropertyEventArgs<T> e)
@@ -93,12 +100,17 @@ namespace Artemis.UI.Screens.ProfileEditor.LayerProperties.Tree
             LayerPropertyViewModel.IsVisible = !LayerProperty.IsHidden;
         }
 
+        private void LayerPropertyOnDataBindingChange(object? sender, LayerPropertyEventArgs<T> e)
+        {
+            NotifyOfPropertyChange(nameof(HasDataBinding));
+        }
+
         #endregion
     }
 
-    public interface ITreePropertyViewModel : IScreen, INotifyPropertyChanged, IDisposable
+    public interface ITreePropertyViewModel : IScreen, IDisposable
     {
         bool HasPropertyInputViewModel { get; }
-        bool DataBindingsOpen { get; set; }
+        bool HasDataBinding { get; }
     }
 }

src/Artemis.UI/Screens/ProfileEditor/LayerProperties/Tree/TreeView.xaml

@@ -96,7 +96,7 @@
                 <Setter Property="IsExpanded" Value="{Binding IsExpanded, Mode=TwoWay}" />
                 <Setter Property="Visibility" Value="{Binding IsVisible, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}" />
                 <Style.Triggers>
-                    <DataTrigger Binding="{Binding TreePropertyViewModel.DataBindingsOpen}" Value="True">
+                    <DataTrigger Binding="{Binding IsHighlighted, Mode=OneWay}" Value="True">
                         <Setter Property="Background" Value="{DynamicResource MaterialDesignPaper}" />
                     </DataTrigger>
                 </Style.Triggers>