Added most of the settings code, doesn't work because SQLite is weird

src/Artemis.Core/Plugins/Models/PluginInfo.cs

@@ -15,21 +15,25 @@ namespace Artemis.Core.Plugins.Models
         /// <summary>
         ///     The plugins GUID
         /// </summary>
+        [JsonProperty(Required = Required.Always)]
         public Guid Guid { get; internal set; }
 
         /// <summary>
         ///     The name of the plugin
         /// </summary>
+        [JsonProperty(Required = Required.Always)]
         public string Name { get; internal set; }
 
         /// <summary>
         ///     The version of the plugin
         /// </summary>
-        public string Version { get; internal set; }
+        [JsonProperty(Required = Required.Always)]
+        public Version Version { get; internal set; }
 
         /// <summary>
         ///     The main entry DLL, should contain a class implementing Plugin
         /// </summary>
+        [JsonProperty(Required = Required.Always)]
         public string Main { get; internal set; }
 
         /// <summary>

src/Artemis.Core/Plugins/Models/PluginSetting.cs

@@ -9,9 +9,9 @@ namespace Artemis.Core.Plugins.Models
     {
         private readonly PluginInfo _pluginInfo;
         private readonly SettingEntity _settingEntity;
-        private readonly SettingRepository _settingRepository;
+        private readonly ISettingRepository _settingRepository;
 
-        internal PluginSetting(PluginInfo pluginInfo, SettingRepository settingRepository, SettingEntity settingEntity)
+        internal PluginSetting(PluginInfo pluginInfo, ISettingRepository settingRepository, SettingEntity settingEntity)
         {
             _pluginInfo = pluginInfo;
             _settingRepository = settingRepository;

src/Artemis.Core/Plugins/Models/PluginSettings.cs

@@ -0,0 +1,35 @@
+using System.Collections.Generic;
+using System.Linq;
+using Artemis.Storage.Entities;
+using Artemis.Storage.Repositories;
+using Newtonsoft.Json;
+
+namespace Artemis.Core.Plugins.Models
+{
+    public class PluginSettings
+    {
+        private readonly PluginInfo _pluginInfo;
+        private readonly ISettingRepository _settingRepository;
+        private readonly Dictionary<string, SettingEntity> _settingEntities;
+
+        public PluginSettings(PluginInfo pluginInfo, ISettingRepository settingRepository)
+        {
+            _pluginInfo = pluginInfo;
+            _settingRepository = settingRepository;
+            _settingEntities = settingRepository.GetByPluginGuid(_pluginInfo.Guid).ToDictionary(se => se.Name);
+        }
+
+        public PluginSetting<T> GetSetting<T>(string name, T defaultValue = default)
+        {
+            if (_settingEntities.ContainsKey(name))
+                return new PluginSetting<T>(_pluginInfo, _settingRepository, _settingEntities[name]);
+
+            var settingEntity = new SettingEntity {Name = name, PluginGuid = _pluginInfo.Guid, Value = JsonConvert.SerializeObject(defaultValue)};
+            _settingRepository.Add(settingEntity);
+            _settingRepository.Save();
+
+            _settingEntities.Add(name, settingEntity);
+            return GetSetting(name, defaultValue);
+        }
+    }
+}

src/Artemis.Core/Plugins/Models/PluginSettingsContainer.cs

@@ -1,30 +0,0 @@
-using System.Collections.Generic;
-using System.Threading.Tasks;
-using Artemis.Storage.Entities;
-using Artemis.Storage.Repositories;
-
-namespace Artemis.Core.Plugins.Models
-{
-    public class PluginSettingsContainer
-    {
-        private readonly PluginInfo _pluginInfo;
-        private readonly SettingRepository _settingRepository;
-        private Task<List<SettingEntity>> _settings;
-
-        internal PluginSettingsContainer(PluginInfo pluginInfo, SettingRepository settingRepository)
-        {
-            _pluginInfo = pluginInfo;
-            _settingRepository = settingRepository;
-        }
-
-        public bool HasSettingChanged(string settingName)
-        {
-            return false;
-        }
-
-        public bool HasAnySettingChanged()
-        {
-            return false;
-        }
-    }
-}