DarthAffe/Artemis
1
0
Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2025-12-12 21:38:38 +00:00
Code Issues Releases Wiki Activity

Allow plugins to opt out of hot reloading

Browse Source
This commit is contained in:
Robert 2023-04-20 13:47:24 +02:00
parent 0c44e4ba22
commit 8a0a162429
2 changed files with 31 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Artemis.Core/Plugins/PluginInfo.cs
View File

@ -28,6 +28,7 @@ public class PluginInfo : CorePropertyChanged, IPrerequisitesSubject
private string _version = null!;
private Uri? _website;
private Uri? _helpPage;
private bool _hotReloadSupported;
internal PluginInfo()
{
@ -156,6 +157,17 @@ public class PluginInfo : CorePropertyChanged, IPrerequisitesSubject
internal set => SetAndNotify(ref _requiresAdmin, value);
}
/// <summary>
/// Gets or sets a boolean indicating whether hot reloading this plugin is supported
/// </summary>
[DefaultValue(true)]
[JsonProperty(DefaultValueHandling = DefaultValueHandling.Populate)]
public bool HotReloadSupported
{
get => _hotReloadSupported;
set => SetAndNotify(ref _hotReloadSupported, value);
}
/// <summary>
/// Gets
/// </summary>

38
src/Artemis.Core/Services/PluginManagementService.cs
View File

@ -938,7 +938,7 @@ internal class PluginManagementService : IPluginManagementService
_hotReloadWatcher.IncludeSubdirectories = true;
_hotReloadWatcher.EnableRaisingEvents = true;
}
private void FileSystemWatcherOnError(object sender, ErrorEventArgs e)
{
_logger.Error(e.GetException(), "File system watcher error");
@ -952,38 +952,38 @@ internal class PluginManagementService : IPluginManagementService
_logger.Warning("Plugin change detected, but could not get plugin directory. {fullPath}", e.FullPath);
return;
}
DirectoryInfo pluginDirectory = new(pluginPath);
Plugin? plugin = GetPluginByDirectory(pluginDirectory);
if (plugin == null)
{
_logger.Warning("Plugin change detected, but could not find plugin. {fullPath}", e.FullPath);
return;
}
_logger.Information("Plugin change detected, reloading. {pluginName}", plugin.Info.Name);
bool wasEnabled = plugin.IsEnabled;
UnloadPlugin(plugin);
Thread.Sleep(500);
Plugin? loadedPlugin = LoadPlugin(pluginDirectory);
if (loadedPlugin == null)
if (!plugin.Info.HotReloadSupported)
{
_logger.Information("Plugin change detected, but hot reload not supported. {pluginName}", plugin.Info.Name);
return;
}
_logger.Information("Plugin change detected, reloading. {pluginName}", plugin.Info.Name);
bool wasEnabled = plugin.IsEnabled;
UnloadPlugin(plugin);
Thread.Sleep(500);
Plugin? loadedPlugin = LoadPlugin(pluginDirectory);
if (loadedPlugin == null)
return;
if (wasEnabled)
{
EnablePlugin(loadedPlugin, true, false);
}
_logger.Information("Plugin reloaded. {fullPath}", e.FullPath);
}
#endregion
}