DarthAffe/Artemis
1
0 Fork 0
mirror of https://github.com/Artemis-RGB/Artemis synced 2026-11-12 03:48:56 +00:00
Code Issues Releases Wiki Activity

Plugins - Don't load incompatible plugins

Browse Source
This commit is contained in:
Robert committed 2022-08-02 21:17:53 +02:00
1 parent dc17253518
commit 73a80ef476
4 files changed
+23 -11
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Artemis.UI/Screens/Plugins/PluginSettingsViewModel.cs
+9 -6
View File
@@ -13,7 +13,7 @@ namespace Artemis.UI.Screens.Plugins;
public class PluginSettingsViewModel : ActivatableViewModelBase
{
private Plugin _plugin;
private readonly Plugin _plugin;
private readonly IPluginManagementService _pluginManagementService;
private readonly INotificationService _notificationService;
@@ -41,10 +41,13 @@ public class PluginSettingsViewModel : ActivatableViewModelBase
bool wasEnabled = _plugin.IsEnabled;
await Task.Run(() => _pluginManagementService.UnloadPlugin(_plugin));
_plugin = _pluginManagementService.LoadPlugin(_plugin.Directory);
if (wasEnabled)
await Task.Run(() => _pluginManagementService.EnablePlugin(_plugin, true, true));
_notificationService.CreateNotification().WithTitle("Reloaded plugin.").Show();
Plugin? plugin = _pluginManagementService.LoadPlugin(_plugin.Directory);
if (plugin != null && wasEnabled)
{
await Task.Run(() => _pluginManagementService.EnablePlugin(plugin, true, true));
_notificationService.CreateNotification().WithTitle("Reloaded plugin.").Show();
}
else if (plugin == null)
_notificationService.CreateNotification().WithTitle("Failed to load plugin after unloading it.").Show();
}
}
src/Artemis.UI/Screens/Settings/Tabs/PluginsTabViewModel.cs
+7 -1
View File
@@ -82,7 +82,13 @@ namespace Artemis.UI.Screens.Settings
try
{
Plugin plugin = _pluginManagementService.ImportPlugin(files[0]);
Plugin? plugin = _pluginManagementService.ImportPlugin(files[0]);
if (plugin == null)
{
await _windowService.ShowConfirmContentDialog("Failed to import plugin", "Make sure it is compatible with the current platform.", "Close", null);
return;
}
SearchPluginInput = plugin.Info.Name;
// Wait for the VM to be created asynchronously (it would be better to respond to some event here)