Cleaned up setting service, lol old approach was dumb

Made PluginSetting<T> act as a singleton

src/Artemis.Core/Services/SettingsService.cs

@@ -1,43 +1,24 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
 using Artemis.Core.Plugins.Models;
 using Artemis.Core.Services.Interfaces;
-using Artemis.Storage.Entities;
 using Artemis.Storage.Repositories.Interfaces;
-using Newtonsoft.Json;
 
 namespace Artemis.Core.Services
 {
     /// <inheritdoc />
     public class SettingsService : ISettingsService
     {
-        private readonly PluginInfo _buildInPluginInfo;
-        private readonly IPluginSettingRepository _pluginSettingRepository;
-        private readonly Dictionary<string, PluginSettingEntity> _settingEntities;
+        private readonly PluginSettings _pluginSettings;
 
         internal SettingsService(IPluginSettingRepository pluginSettingRepository)
         {
-            _pluginSettingRepository = pluginSettingRepository;
-            _buildInPluginInfo = new PluginInfo {Guid = Guid.Parse("ffffffff-ffff-ffff-ffff-ffffffffffff"), Name = "Artemis Core"};
-
-            _settingEntities = pluginSettingRepository.GetByPluginGuid(_buildInPluginInfo.Guid).ToDictionary(se => se.Name);
+            var pluginInfo = new PluginInfo {Guid = Guid.Parse("ffffffff-ffff-ffff-ffff-ffffffffffff"), Name = "Artemis Core"};
+            _pluginSettings = new PluginSettings(pluginInfo, pluginSettingRepository);
         }
 
         public PluginSetting<T> GetSetting<T>(string name, T defaultValue = default(T))
         {
-            lock (_settingEntities)
-            {
-                if (_settingEntities.ContainsKey(name))
-                    return new PluginSetting<T>(_buildInPluginInfo, _pluginSettingRepository, _settingEntities[name]);
-
-                var settingEntity = new PluginSettingEntity {Name = name, PluginGuid = _buildInPluginInfo.Guid, Value = JsonConvert.SerializeObject(defaultValue)};
-                _pluginSettingRepository.Add(settingEntity);
-                _pluginSettingRepository.Save();
-
-                _settingEntities.Add(name, settingEntity);
-                return new PluginSetting<T>(_buildInPluginInfo, _pluginSettingRepository, _settingEntities[name]);
-            }
+            return _pluginSettings.GetSetting(name, defaultValue);
         }
     }