Cleaned up setting service, lol old approach was dumb

Made PluginSetting<T> act as a singleton

src/Artemis.Core/Services/RgbService.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Artemis.Core.Events;
 using Artemis.Core.Plugins.Models;
 using Artemis.Core.RGB.NET;
@@ -21,21 +22,25 @@ namespace Artemis.Core.Services
         private readonly ILogger _logger;
         private readonly TimerUpdateTrigger _updateTrigger;
         private ListLedGroup _background;
-        private PluginSetting<double> _renderScaleSetting;
+        private readonly PluginSetting<double> _renderScaleSetting;
+        private readonly PluginSetting<int> _targetFrameRateSetting;
 
         internal RgbService(ILogger logger, ISettingsService settingsService)
         {
             _logger = logger;
             _renderScaleSetting = settingsService.GetSetting("RenderScale", 1.0);
+            _targetFrameRateSetting = settingsService.GetSetting("TargetFrameRate", 25);
 
             Surface = RGBSurface.Instance;
 
             // Let's throw these for now
             Surface.Exception += SurfaceOnException;
             _renderScaleSetting.SettingChanged += RenderScaleSettingOnSettingChanged;
+            _targetFrameRateSetting.SettingChanged += TargetFrameRateSettingOnSettingChanged;
             _loadedDevices = new List<IRGBDevice>();
-            _updateTrigger = new TimerUpdateTrigger {UpdateFrequency = 1.0 / 25};
+            _updateTrigger = new TimerUpdateTrigger {UpdateFrequency = 1.0 / _targetFrameRateSetting.Value};
             Surface.RegisterUpdateTrigger(_updateTrigger);
+            
         }
 
         /// <inheritdoc />
@@ -82,6 +87,11 @@ namespace Artemis.Core.Services
             UpdateGraphicsDecorator();
         }
 
+        private void TargetFrameRateSettingOnSettingChanged(object sender, EventArgs e)
+        {
+            _updateTrigger.UpdateFrequency = 1.0 / _targetFrameRateSetting.Value;
+        }
+        
         private void SurfaceOnException(ExceptionEventArgs args)
         {
             throw args.Exception;

src/Artemis.Core/Services/SettingsService.cs

@@ -1,43 +1,24 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
 using Artemis.Core.Plugins.Models;
 using Artemis.Core.Services.Interfaces;
-using Artemis.Storage.Entities;
 using Artemis.Storage.Repositories.Interfaces;
-using Newtonsoft.Json;
 
 namespace Artemis.Core.Services
 {
     /// <inheritdoc />
     public class SettingsService : ISettingsService
     {
-        private readonly PluginInfo _buildInPluginInfo;
-        private readonly IPluginSettingRepository _pluginSettingRepository;
-        private readonly Dictionary<string, PluginSettingEntity> _settingEntities;
+        private readonly PluginSettings _pluginSettings;
 
         internal SettingsService(IPluginSettingRepository pluginSettingRepository)
         {
-            _pluginSettingRepository = pluginSettingRepository;
-            _buildInPluginInfo = new PluginInfo {Guid = Guid.Parse("ffffffff-ffff-ffff-ffff-ffffffffffff"), Name = "Artemis Core"};
-
-            _settingEntities = pluginSettingRepository.GetByPluginGuid(_buildInPluginInfo.Guid).ToDictionary(se => se.Name);
+            var pluginInfo = new PluginInfo {Guid = Guid.Parse("ffffffff-ffff-ffff-ffff-ffffffffffff"), Name = "Artemis Core"};
+            _pluginSettings = new PluginSettings(pluginInfo, pluginSettingRepository);
         }
 
         public PluginSetting<T> GetSetting<T>(string name, T defaultValue = default(T))
         {
-            lock (_settingEntities)
-            {
-                if (_settingEntities.ContainsKey(name))
-                    return new PluginSetting<T>(_buildInPluginInfo, _pluginSettingRepository, _settingEntities[name]);
-
-                var settingEntity = new PluginSettingEntity {Name = name, PluginGuid = _buildInPluginInfo.Guid, Value = JsonConvert.SerializeObject(defaultValue)};
-                _pluginSettingRepository.Add(settingEntity);
-                _pluginSettingRepository.Save();
-
-                _settingEntities.Add(name, settingEntity);
-                return new PluginSetting<T>(_buildInPluginInfo, _pluginSettingRepository, _settingEntities[name]);
-            }
+            return _pluginSettings.GetSetting(name, defaultValue);
         }
     }