From 8e833103849ed56368832dc72eb04db8705acd8f Mon Sep 17 00:00:00 2001
From: SpoinkyNL <mail@rbeekman.nl>
Date: Sun, 10 Jan 2021 23:53:41 +0100
Subject: [PATCH 1/3] Auto-update - Added installer update-logic

---
 .../General/GeneralSettingsTabViewModel.cs    |   2 +-
 src/Artemis.UI/Services/UpdateService.cs      | 103 +++++++++++-------
 2 files changed, 63 insertions(+), 42 deletions(-)

diff --git a/src/Artemis.UI/Screens/Settings/Tabs/General/GeneralSettingsTabViewModel.cs b/src/Artemis.UI/Screens/Settings/Tabs/General/GeneralSettingsTabViewModel.cs
index 3b852d910..d6ccc65b3 100644
--- a/src/Artemis.UI/Screens/Settings/Tabs/General/GeneralSettingsTabViewModel.cs
+++ b/src/Artemis.UI/Screens/Settings/Tabs/General/GeneralSettingsTabViewModel.cs
@@ -276,7 +276,7 @@ namespace Artemis.UI.Screens.Settings.Tabs.General
                 return;
 
             CanOfferUpdatesIfFound = false;
-            bool updateFound = await _updateService.OfferUpdatesIfFound();
+            bool updateFound = await _updateService.OfferUpdateIfFound();
             if (!updateFound)
                 _messageService.ShowMessage("You are already running the latest Artemis build. (☞ﾟヮﾟ)☞");
             CanOfferUpdatesIfFound = true;
diff --git a/src/Artemis.UI/Services/UpdateService.cs b/src/Artemis.UI/Services/UpdateService.cs
index fbabfaa8f..8cc364a84 100644
--- a/src/Artemis.UI/Services/UpdateService.cs
+++ b/src/Artemis.UI/Services/UpdateService.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Globalization;
+using System.IO;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Artemis.Core;
@@ -36,42 +37,15 @@ namespace Artemis.UI.Services
             _checkForUpdates.SettingChanged += CheckForUpdatesOnSettingChanged;
         }
 
-        public async Task<double> GetLatestBuildNumber()
+        public async Task<bool> AutoUpdate()
         {
-            // TODO: The URL is hardcoded, that should change in the future
-            string latestBuildUrl = ApiUrl + "build/builds?api-version=6.1-preview.6&branchName=refs/heads/master&resultFilter=succeeded&$top=1";
-            _logger.Debug("Getting latest build number from {latestBuildUrl}", latestBuildUrl);
+            if (!_checkForUpdates.Value)
+                return false;
 
-            // Make the request
-            using HttpClient client = new();
-            HttpResponseMessage httpResponseMessage = await client.GetAsync(latestBuildUrl);
-
-            // Ensure it returned correctly
-            if (!httpResponseMessage.IsSuccessStatusCode)
-            {
-                _logger.Warning("Failed to check for updates, request returned {statusCode}", httpResponseMessage.StatusCode);
-                return 0;
-            }
-
-            // Parse the response
-            string response = await httpResponseMessage.Content.ReadAsStringAsync();
-            try
-            {
-                JToken buildNumberToken = JObject.Parse(response).SelectToken("value[0].buildNumber");
-                if (buildNumberToken != null)
-                    return buildNumberToken.Value<double>();
-
-                _logger.Warning("Failed to find build number at \"value[0].buildNumber\"");
-                return 0;
-            }
-            catch (Exception e)
-            {
-                _logger.Warning(e, "Failed to retrieve build info JSON");
-                return 0;
-            }
+            return await OfferUpdateIfFound();
         }
 
-        public async Task<bool> OfferUpdatesIfFound()
+        public async Task<bool> OfferUpdateIfFound()
         {
             _logger.Information("Checking for updates");
 
@@ -93,6 +67,8 @@ namespace Artemis.UI.Services
                     $"Build {buildNumberDisplay} is available, currently on {Constants.BuildInfo.BuildNumberDisplay}.",
                     PackIconKind.Update
                 );
+
+                await ApplyUpdate(buildNumber);
             }
             else
             {
@@ -113,17 +89,62 @@ namespace Artemis.UI.Services
             return buildNumber > Constants.BuildInfo.BuildNumber;
         }
 
-        public void ApplyUpdate()
+        public async Task<double> GetLatestBuildNumber()
+        {
+            JToken buildInfo = await GetBuildInfo(1);
+            JToken buildNumberToken = buildInfo?.SelectToken("value[0].buildNumber");
+
+            if (buildNumberToken != null)
+                return buildNumberToken.Value<double>();
+
+            _logger.Warning("Failed to find build number at \"value[0].buildNumber\"");
+            return 0;
+        }
+
+        public async Task ApplyUpdate(double buildNumber)
+        {
+            // Get installer build info
+            JToken buildInfo = await GetBuildInfo(6);
+            string installerPath = Path.Combine(Constants.ApplicationFolder, "Installer", "Artemis.Installer.exe");
+
+            // Always update installer if it is missing ^^
+            if (!File.Exists(installerPath))
+                UpdateInstaller(buildInfo);
+            // Compare the creation date of the installer with the build date and update if needed
+        }
+
+        private void UpdateInstaller(JToken buildInfo)
         {
             throw new NotImplementedException();
         }
 
-        public async Task<bool> AutoUpdate()
+        private async Task<JObject> GetBuildInfo(int buildDefinition)
         {
-            if (!_checkForUpdates.Value)
-                return false;
+            string latestBuildUrl = ApiUrl + $"build/builds?definitions=6&resultFilter=succeeded&$top={buildDefinition}&api-version=6.1-preview.6";
+            _logger.Debug("Getting build info from {latestBuildUrl}", latestBuildUrl);
 
-            return await OfferUpdatesIfFound();
+            // Make the request
+            using HttpClient client = new();
+            HttpResponseMessage httpResponseMessage = await client.GetAsync(latestBuildUrl);
+
+            // Ensure it returned correctly
+            if (!httpResponseMessage.IsSuccessStatusCode)
+            {
+                _logger.Warning("Getting build info, request returned {statusCode}", httpResponseMessage.StatusCode);
+                return null;
+            }
+
+            // Parse the response
+            string response = await httpResponseMessage.Content.ReadAsStringAsync();
+            try
+            {
+                return JObject.Parse(response);
+            }
+            catch (Exception e)
+            {
+                _logger.Warning(e, "Failed to retrieve build info JSON");
+                return null;
+            }
         }
 
         #region Event handlers
@@ -145,13 +166,13 @@ namespace Artemis.UI.Services
 
     public interface IUpdateService : IArtemisUIService
     {
-        Task<bool> OfferUpdatesIfFound();
-        Task<bool> IsUpdateAvailable();
-        void ApplyUpdate();
-
         /// <summary>
         ///     If auto-update is enabled this will offer updates if found
         /// </summary>
         Task<bool> AutoUpdate();
+
+        Task<bool> OfferUpdateIfFound();
+        Task<bool> IsUpdateAvailable();
+        Task ApplyUpdate(double buildNumber);
     }
 }
\ No newline at end of file

From e3c906390d4377341d2658492fc0f7c99f19787d Mon Sep 17 00:00:00 2001
From: SpoinkyNL <mail@rbeekman.nl>
Date: Tue, 12 Jan 2021 22:32:24 +0100
Subject: [PATCH 2/3] Auto-update - Added update dialog

---
 .../Settings/Dialogs/UpdateDialogView.xaml    | 37 ++++++++++
 .../Settings/Dialogs/UpdateDialogViewModel.cs | 31 ++++++++
 src/Artemis.UI/Services/UpdateService.cs      | 72 +++++++++++++------
 3 files changed, 119 insertions(+), 21 deletions(-)
 create mode 100644 src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogView.xaml
 create mode 100644 src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs

diff --git a/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogView.xaml b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogView.xaml
new file mode 100644
index 000000000..be9bacf79
--- /dev/null
+++ b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogView.xaml
@@ -0,0 +1,37 @@
+<UserControl x:Class="Artemis.UI.Screens.Settings.Dialogs.UpdateDialogView"
+             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+             xmlns:s="https://github.com/canton7/Stylet"
+             mc:Ignorable="d"
+             d:DesignHeight="450" d:DesignWidth="800">
+    <StackPanel Margin="16">
+        <TextBlock Style="{StaticResource MaterialDesignHeadline6TextBlock}" TextWrapping="Wrap">
+            Update available
+        </TextBlock>
+        <TextBlock Style="{StaticResource MaterialDesignSubtitle1TextBlock}"
+                   Foreground="{DynamicResource MaterialDesignBodyLight}"
+                   Margin="0 20 0 20"
+                   TextWrapping="Wrap">
+            A new Artemis update is available! 🥳<LineBreak/>
+            You are currently running build <Run Text="{Binding CurrentBuild, Mode=OneWay}" /> while the latest build is <Run Text="{Binding LatestBuild, Mode=OneWay}" />. <LineBreak/> <LineBreak/>
+            Updating Artemis will give you the latest bug(fixes), features and improvements.
+        </TextBlock>
+
+        <StackPanel Orientation="Horizontal" HorizontalAlignment="Right" Margin="0 8 0 0">
+            <Button Style="{StaticResource MaterialDesignFlatButton}"
+                    Focusable="False"
+                    IsCancel="True"
+                    Command="{s:Action Cancel}"
+                    Content="LATER" />
+            <Button x:Name="ConfirmButton"
+                    Style="{StaticResource MaterialDesignFlatButton}"
+                    IsDefault="True"
+                    Focusable="True"
+                    Command="{s:Action Update}"
+                    Content="UPDATE" />
+        </StackPanel>
+
+    </StackPanel>
+</UserControl>
\ No newline at end of file
diff --git a/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs
new file mode 100644
index 000000000..d5819bd9d
--- /dev/null
+++ b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs
@@ -0,0 +1,31 @@
+using System.Threading.Tasks;
+using Artemis.Core;
+using Artemis.UI.Services;
+using Artemis.UI.Shared.Services;
+using Newtonsoft.Json.Linq;
+
+namespace Artemis.UI.Screens.Settings.Dialogs
+{
+    public class UpdateDialogViewModel : DialogViewModelBase
+    {
+        private readonly JToken _buildInfo;
+        private readonly IUpdateService _updateService;
+
+        public UpdateDialogViewModel(JToken buildInfo, IUpdateService updateService)
+        {
+            _buildInfo = buildInfo;
+            _updateService = updateService;
+            CurrentBuild = Constants.BuildInfo.BuildNumberDisplay;
+            LatestBuild = buildInfo?.SelectToken("value[0].buildNumber")?.Value<string>();
+        }
+
+        public string CurrentBuild { get; }
+        public string LatestBuild { get; }
+
+        public async Task Update()
+        {
+            await _updateService.ApplyUpdate();
+            Session.Close();
+        }
+    }
+}
\ No newline at end of file
diff --git a/src/Artemis.UI/Services/UpdateService.cs b/src/Artemis.UI/Services/UpdateService.cs
index 8cc364a84..f4cee099d 100644
--- a/src/Artemis.UI/Services/UpdateService.cs
+++ b/src/Artemis.UI/Services/UpdateService.cs
@@ -1,10 +1,14 @@
 using System;
+using System.Collections.Generic;
+using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Artemis.Core;
 using Artemis.Core.Services;
+using Artemis.UI.Exceptions;
+using Artemis.UI.Screens.Settings.Dialogs;
 using Artemis.UI.Services.Interfaces;
 using Artemis.UI.Shared.Services;
 using MaterialDesignThemes.Wpf;
@@ -49,7 +53,13 @@ namespace Artemis.UI.Services
         {
             _logger.Information("Checking for updates");
 
-            double buildNumber = await GetLatestBuildNumber();
+            JToken buildInfo = await GetBuildInfo(1);
+            JToken buildNumberToken = buildInfo?.SelectToken("value[0].buildNumber");
+
+            if (buildNumberToken == null)
+                throw new ArtemisUIException("Failed to find build number at \"value[0].buildNumber\"");
+            double buildNumber = buildNumberToken.Value<double>();
+
             string buildNumberDisplay = buildNumber.ToString(CultureInfo.InvariantCulture);
             _logger.Information("Latest build is {buildNumber}, we're running {localBuildNumber}", buildNumberDisplay, Constants.BuildInfo.BuildNumberDisplay);
 
@@ -57,8 +67,7 @@ namespace Artemis.UI.Services
                 return false;
 
             if (_windowService.IsMainWindowOpen)
-            {
-            }
+                await OfferUpdate(buildInfo);
             else if (_autoInstallUpdates.Value)
             {
                 // Lets go
@@ -67,8 +76,7 @@ namespace Artemis.UI.Services
                     $"Build {buildNumberDisplay} is available, currently on {Constants.BuildInfo.BuildNumberDisplay}.",
                     PackIconKind.Update
                 );
-
-                await ApplyUpdate(buildNumber);
+                await ApplyUpdate();
             }
             else
             {
@@ -83,45 +91,67 @@ namespace Artemis.UI.Services
             return true;
         }
 
-        public async Task<bool> IsUpdateAvailable()
+        private async Task OfferUpdate(JToken buildInfo)
         {
-            double buildNumber = await GetLatestBuildNumber();
-            return buildNumber > Constants.BuildInfo.BuildNumber;
+            await _dialogService.ShowDialog<UpdateDialogViewModel>(new Dictionary<string, object> {{"buildInfo", buildInfo}});
         }
 
-        public async Task<double> GetLatestBuildNumber()
+        public async Task<bool> IsUpdateAvailable()
         {
             JToken buildInfo = await GetBuildInfo(1);
             JToken buildNumberToken = buildInfo?.SelectToken("value[0].buildNumber");
 
             if (buildNumberToken != null)
-                return buildNumberToken.Value<double>();
+                return buildNumberToken.Value<double>() > Constants.BuildInfo.BuildNumber;
 
-            _logger.Warning("Failed to find build number at \"value[0].buildNumber\"");
-            return 0;
+            _logger.Warning("IsUpdateAvailable: Failed to find build number at \"value[0].buildNumber\"");
+            return false;
         }
 
-        public async Task ApplyUpdate(double buildNumber)
+        public async Task ApplyUpdate()
         {
-            // Get installer build info
+            _logger.Information("Applying update");
+
+            // Ensure the installer is up-to-date, get installer build info
             JToken buildInfo = await GetBuildInfo(6);
             string installerPath = Path.Combine(Constants.ApplicationFolder, "Installer", "Artemis.Installer.exe");
 
             // Always update installer if it is missing ^^
             if (!File.Exists(installerPath))
-                UpdateInstaller(buildInfo);
+                await UpdateInstaller();
             // Compare the creation date of the installer with the build date and update if needed
+            else if (File.GetLastWriteTime(installerPath) < buildInfo["finishTime"].Value<DateTime>())
+                await UpdateInstaller();
+
+            _logger.Information("Running installer at {installerPath}", installerPath);
+            Process.Start(installerPath, "-autoupdate");
         }
 
-        private void UpdateInstaller(JToken buildInfo)
+        private async Task UpdateInstaller()
         {
-            throw new NotImplementedException();
+            string downloadUrl = "https://builds.artemis-rgb.com/binaries/Artemis.Installer.exe";
+            string installerDirectory = Path.Combine(Constants.ApplicationFolder, "Installer");
+            string installerPath = Path.Combine(installerDirectory, "Artemis.Installer.exe");
+
+            _logger.Information("UpdateInstaller: Downloading installer from {downloadUrl}", downloadUrl);
+            using HttpClient client = new();
+            HttpResponseMessage httpResponseMessage = await client.GetAsync(downloadUrl);
+            if (!httpResponseMessage.IsSuccessStatusCode)
+                throw new ArtemisUIException($"Failed to download installer, status code {httpResponseMessage.StatusCode}");
+
+            _logger.Information("UpdateInstaller: Writing installer file to {installerPath}", installerPath);
+            if (File.Exists(installerPath))
+                File.Delete(installerPath);
+            else if (!Directory.Exists(installerDirectory))
+                Directory.CreateDirectory(installerDirectory);
+            await using FileStream fs = new(installerPath, FileMode.Create, FileAccess.Write, FileShare.None);
+            await httpResponseMessage.Content.CopyToAsync(fs);
         }
 
         private async Task<JObject> GetBuildInfo(int buildDefinition)
         {
             string latestBuildUrl = ApiUrl + $"build/builds?definitions=6&resultFilter=succeeded&$top={buildDefinition}&api-version=6.1-preview.6";
-            _logger.Debug("Getting build info from {latestBuildUrl}", latestBuildUrl);
+            _logger.Debug("GetBuildInfo: Getting build info from {latestBuildUrl}", latestBuildUrl);
 
             // Make the request
             using HttpClient client = new();
@@ -130,7 +160,7 @@ namespace Artemis.UI.Services
             // Ensure it returned correctly
             if (!httpResponseMessage.IsSuccessStatusCode)
             {
-                _logger.Warning("Getting build info, request returned {statusCode}", httpResponseMessage.StatusCode);
+                _logger.Warning("GetBuildInfo: Getting build info, request returned {statusCode}", httpResponseMessage.StatusCode);
                 return null;
             }
 
@@ -142,7 +172,7 @@ namespace Artemis.UI.Services
             }
             catch (Exception e)
             {
-                _logger.Warning(e, "Failed to retrieve build info JSON");
+                _logger.Warning(e, "GetBuildInfo: Failed to retrieve build info JSON");
                 return null;
             }
         }
@@ -173,6 +203,6 @@ namespace Artemis.UI.Services
 
         Task<bool> OfferUpdateIfFound();
         Task<bool> IsUpdateAvailable();
-        Task ApplyUpdate(double buildNumber);
+        Task ApplyUpdate();
     }
 }
\ No newline at end of file

From 36b4a10f40e260011ac02f8edd923a4feeecffda Mon Sep 17 00:00:00 2001
From: SpoinkyNL <mail@rbeekman.nl>
Date: Fri, 15 Jan 2021 16:15:37 +0100
Subject: [PATCH 3/3] Update - Display exceptions

Update - Run installer as admin so it well, works
---
 .../Settings/Dialogs/UpdateDialogViewModel.cs | 30 +++++++++++++++--
 src/Artemis.UI/Services/UpdateService.cs      | 33 ++++++++++++++++---
 2 files changed, 55 insertions(+), 8 deletions(-)

diff --git a/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs
index d5819bd9d..a048ee1f8 100644
--- a/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs
+++ b/src/Artemis.UI/Screens/Settings/Dialogs/UpdateDialogViewModel.cs
@@ -1,4 +1,5 @@
-using System.Threading.Tasks;
+using System;
+using System.Threading.Tasks;
 using Artemis.Core;
 using Artemis.UI.Services;
 using Artemis.UI.Shared.Services;
@@ -9,12 +10,16 @@ namespace Artemis.UI.Screens.Settings.Dialogs
     public class UpdateDialogViewModel : DialogViewModelBase
     {
         private readonly JToken _buildInfo;
+        private readonly IDialogService _dialogService;
         private readonly IUpdateService _updateService;
+        private bool _canUpdate = true;
 
-        public UpdateDialogViewModel(JToken buildInfo, IUpdateService updateService)
+        public UpdateDialogViewModel(JToken buildInfo, IUpdateService updateService, IDialogService dialogService)
         {
             _buildInfo = buildInfo;
             _updateService = updateService;
+            _dialogService = dialogService;
+            
             CurrentBuild = Constants.BuildInfo.BuildNumberDisplay;
             LatestBuild = buildInfo?.SelectToken("value[0].buildNumber")?.Value<string>();
         }
@@ -22,9 +27,28 @@ namespace Artemis.UI.Screens.Settings.Dialogs
         public string CurrentBuild { get; }
         public string LatestBuild { get; }
 
+        public bool CanUpdate
+        {
+            get => _canUpdate;
+            set => SetAndNotify(ref _canUpdate, value);
+        }
+
         public async Task Update()
         {
-            await _updateService.ApplyUpdate();
+            try
+            {
+                CanUpdate = false;
+                await _updateService.ApplyUpdate();
+            }
+            catch (Exception e)
+            {
+                _dialogService.ShowExceptionDialog("An exception occurred while applying the update", e);
+            }
+            finally
+            {
+                CanUpdate = true;
+            }
+
             Session.Close();
         }
     }
diff --git a/src/Artemis.UI/Services/UpdateService.cs b/src/Artemis.UI/Services/UpdateService.cs
index f4cee099d..00ebcceba 100644
--- a/src/Artemis.UI/Services/UpdateService.cs
+++ b/src/Artemis.UI/Services/UpdateService.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.Globalization;
 using System.IO;
@@ -110,21 +111,43 @@ namespace Artemis.UI.Services
 
         public async Task ApplyUpdate()
         {
-            _logger.Information("Applying update");
+            _logger.Information("ApplyUpdate: Applying update");
 
             // Ensure the installer is up-to-date, get installer build info
             JToken buildInfo = await GetBuildInfo(6);
+            JToken finishTimeToken = buildInfo?.SelectToken("value[0].finishTime");
             string installerPath = Path.Combine(Constants.ApplicationFolder, "Installer", "Artemis.Installer.exe");
 
             // Always update installer if it is missing ^^
             if (!File.Exists(installerPath))
                 await UpdateInstaller();
             // Compare the creation date of the installer with the build date and update if needed
-            else if (File.GetLastWriteTime(installerPath) < buildInfo["finishTime"].Value<DateTime>())
-                await UpdateInstaller();
+            else
+            {
+                if (finishTimeToken == null)
+                    _logger.Warning("ApplyUpdate: Failed to find build finish time at \"value[0].finishTime\", not updating the installer.");
+                else if (File.GetLastWriteTime(installerPath) < finishTimeToken.Value<DateTime>())
+                    await UpdateInstaller();
+            }
 
-            _logger.Information("Running installer at {installerPath}", installerPath);
-            Process.Start(installerPath, "-autoupdate");
+            _logger.Information("ApplyUpdate: Running installer at {installerPath}", installerPath);
+
+            try
+            {
+                Process.Start(new ProcessStartInfo(installerPath, "-autoupdate")
+                {
+                    UseShellExecute = true,
+                    Verb = "runas"
+                });
+            }
+            catch (Win32Exception e)
+            {
+                if (e.NativeErrorCode == 0x4c7)
+                    _logger.Warning("ApplyUpdate: Operation was cancelled, user likely clicked No in UAC dialog.");
+                else
+                    throw;
+            }
+            
         }
 
         private async Task UpdateInstaller()