Plugins - Removed plugin info from constructor

src/Artemis.Core/Plugins/Abstract/DataModelExpansion.cs

@@ -1,6 +1,4 @@
-using Artemis.Core.Plugins.Models;
-
-namespace Artemis.Core.Plugins.Abstract
+namespace Artemis.Core.Plugins.Abstract
 {
     /// <inheritdoc />
     /// <summary>
@@ -8,10 +6,6 @@ namespace Artemis.Core.Plugins.Abstract
     /// </summary>
     public abstract class DataModelExpansion : Plugin
     {
-        protected DataModelExpansion(PluginInfo pluginInfo) : base(pluginInfo)
-        {
-        }
-
         public abstract void Update(double deltaTime);
     }
 }

src/Artemis.Core/Plugins/Abstract/DataModels/Attributes/DataModelProperty.cs

@@ -2,7 +2,7 @@
 
 namespace Artemis.Core.Plugins.Abstract.DataModels.Attributes
 {
-    [AttributeUsage(System.AttributeTargets.Property)]
+    [AttributeUsage(AttributeTargets.Property)]
     public class DataModelPropertyAttribute : Attribute
     {
         /// <summary>

src/Artemis.Core/Plugins/Abstract/DeviceProvider.cs

@@ -1,7 +1,6 @@
 using System;
 using System.IO;
 using Artemis.Core.Extensions;
-using Artemis.Core.Plugins.Models;
 using Ninject;
 using RGB.NET.Core;
 using Serilog;
@@ -14,7 +13,7 @@ namespace Artemis.Core.Plugins.Abstract
     /// </summary>
     public abstract class DeviceProvider : Plugin
     {
-        protected DeviceProvider(PluginInfo pluginInfo, IRGBDeviceProvider rgbDeviceProvider) : base(pluginInfo)
+        protected DeviceProvider(IRGBDeviceProvider rgbDeviceProvider)
         {
             RgbDeviceProvider = rgbDeviceProvider ?? throw new ArgumentNullException(nameof(rgbDeviceProvider));
         }
@@ -24,6 +23,11 @@ namespace Artemis.Core.Plugins.Abstract
         [Inject]
         public ILogger Logger { get; set; }
 
+        public override void DisablePlugin()
+        {
+            // Does not happen with device providers, they require Artemis to restart
+        }
+
         protected void ResolveAbsolutePath(Type type, object sender, ResolvePathEventArgs e)
         {
             if (sender.GetType().IsGenericType(type))
@@ -42,10 +46,5 @@ namespace Artemis.Core.Plugins.Abstract
                 }
             }
         }
-
-        public override void DisablePlugin()
-        {
-            // Does not happen with device providers, they require Artemis to restart
-        }
     }
 }

src/Artemis.Core/Plugins/Abstract/LayerBrushProvider.cs

@@ -1,7 +1,8 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using Artemis.Core.Plugins.Exceptions;
 using Artemis.Core.Plugins.LayerBrush;
-using Artemis.Core.Plugins.Models;
+using Artemis.Core.Plugins.LayerBrush.Abstract;
 
 namespace Artemis.Core.Plugins.Abstract
 {
@@ -13,15 +14,32 @@ namespace Artemis.Core.Plugins.Abstract
     {
         private readonly List<LayerBrushDescriptor> _layerBrushDescriptors;
 
-        protected LayerBrushProvider(PluginInfo pluginInfo) : base(pluginInfo)
+        protected LayerBrushProvider()
         {
             _layerBrushDescriptors = new List<LayerBrushDescriptor>();
         }
 
+        /// <summary>
+        ///     A read-only collection of all layer brushes added with <see cref="AddLayerBrushDescriptor{T}" />
+        /// </summary>
         public ReadOnlyCollection<LayerBrushDescriptor> LayerBrushDescriptors => _layerBrushDescriptors.AsReadOnly();
 
+        /// <summary>
+        ///     Adds a layer brush descriptor for a given layer brush, so that it appears in the UI.
+        ///     <para>Note: You do not need to manually remove these on disable</para>
+        /// </summary>
+        /// <typeparam name="T">The type of the layer brush you wish to register</typeparam>
+        /// <param name="displayName">The name to display in the UI</param>
+        /// <param name="description">The description to display in the UI</param>
+        /// <param name="icon">
+        ///     The Material icon to display in the UI, a full reference can be found
+        ///     <see href="https://materialdesignicons.com">here</see>
+        /// </param>
         protected void AddLayerBrushDescriptor<T>(string displayName, string description, string icon) where T : BaseLayerBrush
         {
+            if (!Enabled)
+                throw new ArtemisPluginException(PluginInfo, "Can only add a layer brush descriptor when the plugin is enabled");
+
             _layerBrushDescriptors.Add(new LayerBrushDescriptor(displayName, description, icon, typeof(T), this));
         }
     }

src/Artemis.Core/Plugins/Abstract/LayerEffectProvider.cs

@@ -1,7 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Text;
-using Artemis.Core.Plugins.Models;
 
 namespace Artemis.Core.Plugins.Abstract
 {
@@ -11,10 +8,6 @@ namespace Artemis.Core.Plugins.Abstract
     /// </summary>
     public class LayerEffectProvider : Plugin
     {
-        public LayerEffectProvider(PluginInfo pluginInfo) : base(pluginInfo)
-        {
-        }
-
         public override void EnablePlugin()
         {
             throw new NotImplementedException();
@@ -25,4 +18,4 @@ namespace Artemis.Core.Plugins.Abstract
             throw new NotImplementedException();
         }
     }
-}
+}

src/Artemis.Core/Plugins/Abstract/Module.cs

@@ -2,7 +2,6 @@
 using Artemis.Core.Models.Surface;
 using Artemis.Core.Plugins.Abstract.DataModels;
 using Artemis.Core.Plugins.Abstract.ViewModels;
-using Artemis.Core.Plugins.Models;
 using SkiaSharp;
 
 namespace Artemis.Core.Plugins.Abstract
@@ -13,10 +12,6 @@ namespace Artemis.Core.Plugins.Abstract
     /// </summary>
     public abstract class Module : Plugin
     {
-        protected Module(PluginInfo pluginInfo) : base(pluginInfo)
-        {
-        }
-
         /// <summary>
         ///     The modules display name that's shown in the menu
         /// </summary>

src/Artemis.Core/Plugins/Abstract/Plugin.cs

@@ -10,11 +10,6 @@ namespace Artemis.Core.Plugins.Abstract
     /// </summary>
     public abstract class Plugin : IDisposable
     {
-        internal Plugin(PluginInfo pluginInfo)
-        {
-            PluginInfo = pluginInfo ?? throw new ArgumentNullException(nameof(pluginInfo));
-        }
-
         public PluginInfo PluginInfo { get; internal set; }
 
         /// <summary>
@@ -28,11 +23,6 @@ namespace Artemis.Core.Plugins.Abstract
         /// </summary>
         public bool HasConfigurationViewModel { get; protected set; }
 
-        public void Dispose()
-        {
-            DisablePlugin();
-        }
-
         /// <summary>
         ///     Called when the plugin is activated
         /// </summary>
@@ -52,21 +42,26 @@ namespace Artemis.Core.Plugins.Abstract
         {
             return null;
         }
-        
+
         internal void SetEnabled(bool enable)
         {
             if (enable && !Enabled)
             {
+                Enabled = true;
                 EnablePlugin();
                 OnPluginEnabled();
             }
             else if (!enable && Enabled)
             {
+                Enabled = false;
                 DisablePlugin();
                 OnPluginDisabled();
             }
+        }
 
-            Enabled = enable;
+        public void Dispose()
+        {
+            DisablePlugin();
         }
 
         #region Events

src/Artemis.Core/Plugins/Abstract/ProfileModule.cs

@@ -2,17 +2,12 @@
 using Artemis.Core.Exceptions;
 using Artemis.Core.Models.Profile;
 using Artemis.Core.Models.Surface;
-using Artemis.Core.Plugins.Models;
 using SkiaSharp;
 
 namespace Artemis.Core.Plugins.Abstract
 {
     public abstract class ProfileModule : Module
     {
-        protected ProfileModule(PluginInfo pluginInfo) : base(pluginInfo)
-        {
-        }
-
         public Profile ActiveProfile { get; private set; }
 
         /// <inheritdoc />

src/Artemis.Core/Plugins/LayerBrush/Abstract/BaseLayerBrush.cs

@@ -1,25 +1,16 @@
 using System;
-using System.Linq;
 using Artemis.Core.Models.Profile;
 using Artemis.Core.Plugins.Models;
 using Artemis.Core.Services.Interfaces;
-using RGB.NET.Core;
-using RGB.NET.Groups;
 using SkiaSharp;
 
-namespace Artemis.Core.Plugins.LayerBrush
+namespace Artemis.Core.Plugins.LayerBrush.Abstract
 {
     /// <summary>
     ///     For internal use only, please use <see cref="LayerBrush{T}" /> or <see cref="RgbNetLayerBrush{T}" /> or instead
     /// </summary>
     public abstract class BaseLayerBrush : IDisposable
     {
-        protected BaseLayerBrush(Layer layer, LayerBrushDescriptor descriptor)
-        {
-            Layer = layer;
-            Descriptor = descriptor;
-        }
-
         /// <summary>
         ///     Gets the layer this brush is applied to
         /// </summary>
@@ -45,6 +36,14 @@ namespace Artemis.Core.Plugins.LayerBrush
         /// </summary>
         public virtual LayerPropertyGroup BaseProperties => null;
 
+        public void Dispose()
+        {
+            DisableLayerBrush();
+            Dispose(true);
+
+            GC.SuppressFinalize(this);
+        }
+
         /// <summary>
         ///     Called when the layer brush is activated
         /// </summary>
@@ -67,15 +66,8 @@ namespace Artemis.Core.Plugins.LayerBrush
 
         internal abstract void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
 
-        /// <summary>
-        ///     Called when Artemis needs an instance of the RGB.NET brush you are implementing
-        /// </summary>
-        /// <returns>Your RGB.NET brush</returns>
-        internal abstract IBrush InternalGetBrush();
-
-        public void Dispose()
+        internal virtual void Dispose(bool disposing)
         {
-            DisableLayerBrush();
         }
     }
 

src/Artemis.Core/Plugins/LayerBrush/Abstract/LayerBrush.cs

@@ -1,14 +1,12 @@
-using System;
-using Artemis.Core.Models.Profile;
+using Artemis.Core.Models.Profile;
 using Artemis.Core.Services.Interfaces;
-using RGB.NET.Core;
 using SkiaSharp;
 
-namespace Artemis.Core.Plugins.LayerBrush
+namespace Artemis.Core.Plugins.LayerBrush.Abstract
 {
     public abstract class LayerBrush<T> : PropertiesLayerBrush<T> where T : LayerPropertyGroup
     {
-        protected LayerBrush(Layer layer, LayerBrushDescriptor descriptor) : base(layer, descriptor)
+        protected LayerBrush()
         {
             BrushType = LayerBrushType.Regular;
         }
@@ -23,7 +21,7 @@ namespace Artemis.Core.Plugins.LayerBrush
         /// <param name="path">The path to be filled, represents the shape</param>
         /// <param name="paint">The paint to be used to fill the shape</param>
         public abstract void Render(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
-        
+
         internal override void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
         {
             // Move the canvas to the top-left of the render path
@@ -34,11 +32,6 @@ namespace Artemis.Core.Plugins.LayerBrush
             Render(canvas, canvasInfo, path, paint);
         }
 
-        internal override IBrush InternalGetBrush()
-        {
-            throw new NotImplementedException("Regular layer brushes do not implement InternalGetBrush");
-        }
-
         internal override void Initialize(ILayerService layerService)
         {
             InitializeProperties(layerService);

src/Artemis.Core/Plugins/LayerBrush/Abstract/PropertiesLayerBrush.cs

@@ -3,7 +3,7 @@ using Artemis.Core.Models.Profile;
 using Artemis.Core.Plugins.Exceptions;
 using Artemis.Core.Services.Interfaces;
 
-namespace Artemis.Core.Plugins.LayerBrush
+namespace Artemis.Core.Plugins.LayerBrush.Abstract
 {
     /// <summary>
     ///     For internal use only, please use <see cref="LayerBrush{T}" /> or <see cref="RgbNetLayerBrush{T}" /> or instead
@@ -12,10 +12,6 @@ namespace Artemis.Core.Plugins.LayerBrush
     {
         private T _properties;
 
-        protected PropertiesLayerBrush(Layer layer, LayerBrushDescriptor descriptor) : base(layer, descriptor)
-        {
-        }
-
         /// <summary>
         ///     Gets whether all properties on this brush are initialized
         /// </summary>
@@ -43,8 +39,9 @@ namespace Artemis.Core.Plugins.LayerBrush
         {
             Properties = Activator.CreateInstance<T>();
             Properties.InitializeProperties(layerService, Layer, "LayerBrush.");
-            EnableLayerBrush();
             PropertiesInitialized = true;
+
+            EnableLayerBrush();
         }
     }
 }

src/Artemis.Core/Plugins/LayerBrush/Abstract/RgbNetLayerBrush.cs

@@ -6,43 +6,26 @@ using RGB.NET.Core;
 using RGB.NET.Groups;
 using SkiaSharp;
 
-namespace Artemis.Core.Plugins.LayerBrush
+namespace Artemis.Core.Plugins.LayerBrush.Abstract
 {
     public abstract class RgbNetLayerBrush<T> : PropertiesLayerBrush<T> where T : LayerPropertyGroup
     {
-        protected RgbNetLayerBrush(Layer layer, LayerBrushDescriptor descriptor) : base(layer, descriptor)
+        protected RgbNetLayerBrush()
         {
             BrushType = LayerBrushType.RgbNet;
-            LedGroup = new ListLedGroup();
-
-            Layer = layer;
-            Layer.RenderPropertiesUpdated += LayerOnRenderPropertiesUpdated;
         }
 
         /// <summary>
-        ///     The LED group this layer brush is applied to
+        ///     The LED group this layer effect is applied to
         /// </summary>
         public ListLedGroup LedGroup { get; internal set; }
 
         /// <summary>
-        ///     Called when Artemis needs an instance of the RGB.NET brush you are implementing
+        ///     Called when Artemis needs an instance of the RGB.NET effect you are implementing
         /// </summary>
-        /// <returns>Your RGB.NET brush</returns>
+        /// <returns>Your RGB.NET effect</returns>
         public abstract IBrush GetBrush();
 
-        public sealed override void Dispose()
-        {
-            Layer.RenderPropertiesUpdated -= LayerOnRenderPropertiesUpdated;
-            LedGroup.Detach();
-
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        protected virtual void Dispose(bool disposing)
-        {
-        }
-
         internal void UpdateLedGroup()
         {
             // TODO: This simply renders it on top of the rest, get a ZIndex based on layer position
@@ -57,19 +40,28 @@ namespace Artemis.Core.Plugins.LayerBrush
 
         internal override void Initialize(ILayerService layerService)
         {
+            LedGroup = new ListLedGroup();
+            Layer.RenderPropertiesUpdated += LayerOnRenderPropertiesUpdated;
+
             InitializeProperties(layerService);
             UpdateLedGroup();
         }
 
-        // Not used in this brush type
-        internal override void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
+        internal override void Dispose(bool disposing)
         {
-            throw new NotImplementedException("RGB.NET layer brushes do not implement InternalRender");
+            if (disposing)
+            {
+                Layer.RenderPropertiesUpdated -= LayerOnRenderPropertiesUpdated;
+                LedGroup.Detach();
+            }
+
+            base.Dispose(disposing);
         }
 
-        internal override IBrush InternalGetBrush()
+        // Not used in this effect type
+        internal override void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
         {
-            return GetBrush();
+            throw new NotImplementedException("RGB.NET layer effectes do not implement InternalRender");
         }
 
         private void LayerOnRenderPropertiesUpdated(object sender, EventArgs e)

src/Artemis.Core/Plugins/LayerEffect/Abstract/BaseLayerEffect.cs

@@ -0,0 +1,94 @@
+using System;
+using Artemis.Core.Models.Profile;
+using Artemis.Core.Plugins.Models;
+using Artemis.Core.Services.Interfaces;
+using SkiaSharp;
+
+namespace Artemis.Core.Plugins.LayerEffect.Abstract
+{
+    /// <summary>
+    ///     For internal use only, please use <see cref="LayerEffect" /> instead
+    /// </summary>
+    public abstract class BaseLayerEffect : IDisposable
+    {
+        /// <summary>
+        ///     Gets the layer this effect is applied to
+        /// </summary>
+        public Layer Layer { get; internal set; }
+
+        /// <summary>
+        ///     Gets the folder this effect is applied to
+        /// </summary>
+        public Folder Folder { get; internal set; }
+
+        /// <summary>
+        ///     Gets the descriptor of this effect
+        /// </summary>
+        public LayerEffectDescriptor Descriptor { get; internal set; }
+
+        /// <summary>
+        ///     Gets the plugin info that defined this effect
+        /// </summary>
+        public PluginInfo PluginInfo => Descriptor.LayerEffectProvider.PluginInfo;
+
+        /// <summary>
+        ///     Gets a reference to the layer property group without knowing it's type
+        /// </summary>
+        public virtual LayerPropertyGroup BaseProperties => null;
+
+        public void Dispose()
+        {
+            DisableLayerEffect();
+        }
+
+        /// <summary>
+        ///     Called when the layer brush is activated
+        /// </summary>
+        public abstract void EnableLayerEffect();
+
+        /// <summary>
+        ///     Called when the layer brush is deactivated
+        /// </summary>
+        public abstract void DisableLayerEffect();
+
+        /// <summary>
+        ///     Called before rendering every frame, write your update logic here
+        /// </summary>
+        /// <param name="deltaTime"></param>
+        public abstract void Update(double deltaTime);
+
+        /// <summary>
+        ///     Called before the layer or folder will be rendered
+        /// </summary>
+        public abstract void PreProcess(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
+
+        /// <summary>
+        ///     Called after the layer of folder has been rendered
+        /// </summary>
+        public abstract void PostProcess(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
+
+        internal void InternalPreProcess(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
+        {
+            // Move the canvas to the top-left of the render path
+            canvas.Translate(path.Bounds.Left, path.Bounds.Top);
+            // Pass the render path to the layer effect positioned at 0,0
+            path.Transform(SKMatrix.MakeTranslation(path.Bounds.Left * -1, path.Bounds.Top * -1));
+
+            PreProcess(canvas, canvasInfo, path, paint);
+        }
+
+        internal void InternalPostProcess(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
+        {
+            // Move the canvas to the top-left of the render path
+            canvas.Translate(path.Bounds.Left, path.Bounds.Top);
+            // Pass the render path to the layer effect positioned at 0,0
+            path.Transform(SKMatrix.MakeTranslation(path.Bounds.Left * -1, path.Bounds.Top * -1));
+
+            PostProcess(canvas, canvasInfo, path, paint);
+        }
+
+        // Not only is this needed to initialize properties on the layer effects, it also prevents implementing anything
+        // but LayerEffect<T> outside the core
+        internal abstract void Initialize(ILayerService layerService);
+    }
+}

src/Artemis.Core/Plugins/LayerEffect/Abstract/LayerEffect.cs

@@ -0,0 +1,58 @@
+using System;
+using Artemis.Core.Models.Profile;
+using Artemis.Core.Plugins.Exceptions;
+using Artemis.Core.Services.Interfaces;
+
+namespace Artemis.Core.Plugins.LayerEffect.Abstract
+{
+    /// <summary>
+    ///     For internal use only, please use <see cref="LayerEffect" /> instead
+    /// </summary>
+    public abstract class LayerEffect<T> : BaseLayerEffect where T : LayerPropertyGroup
+    {
+        private T _properties;
+
+        /// <summary>
+        ///     Gets whether all properties on this effect are initialized
+        /// </summary>
+        public bool PropertiesInitialized { get; internal set; }
+
+        /// <inheritdoc />
+        public override LayerPropertyGroup BaseProperties => Properties;
+
+        /// <summary>
+        ///     Gets the properties of this effect.
+        /// </summary>
+        public T Properties
+        {
+            get
+            {
+                // I imagine a null reference here can be confusing, so lets throw an exception explaining what to do
+                if (_properties == null)
+                    throw new ArtemisPluginException("Cannot access effect properties until OnPropertiesInitialized has been called");
+                return _properties;
+            }
+            internal set => _properties = value;
+        }
+
+        /// <summary>
+        ///     Called when all layer properties in this effect have been initialized
+        /// </summary>
+        protected virtual void OnPropertiesInitialized()
+        {
+        }
+
+        internal void InitializeProperties(ILayerService layerService)
+        {
+            Properties = Activator.CreateInstance<T>();
+            Properties.InitializeProperties(layerService, Layer, "LayerEffect.");
+            OnPropertiesInitialized();
+            PropertiesInitialized = true;
+        }
+
+        internal override void Initialize(ILayerService layerService)
+        {
+            InitializeProperties(layerService);
+        }
+    }
+}

src/Artemis.Core/Plugins/LayerEffect/BaseLayerEffect.cs

@@ -1,64 +0,0 @@
-using System;
-using Artemis.Core.Models.Profile;
-using Artemis.Core.Plugins.Models;
-using Artemis.Core.Services.Interfaces;
-using RGB.NET.Core;
-using SkiaSharp;
-
-namespace Artemis.Core.Plugins.LayerEffect
-{
-    /// <summary>
-    ///     For internal use only, please use <see cref="LayerEffect" /> instead
-    /// </summary>
-    public abstract class BaseLayerEffect : IDisposable
-    {
-        protected BaseLayerEffect(Layer layer, LayerEffectDescriptor descriptor)
-        {
-            Layer = layer;
-            Descriptor = descriptor;
-        }
-
-        /// <summary>
-        ///     Gets the layer this brush is applied to
-        /// </summary>
-        public Layer Layer { get; internal set; }
-
-        /// <summary>
-        ///     Gets the descriptor of this brush
-        /// </summary>
-        public LayerEffectDescriptor Descriptor { get; internal set; }
-
-        /// <summary>
-        ///     Gets the plugin info that defined this brush
-        /// </summary>
-        public PluginInfo PluginInfo => Descriptor.LayerEffectProvider.PluginInfo;
-
-        /// <summary>
-        ///     Gets a reference to the layer property group without knowing it's type
-        /// </summary>
-        public virtual LayerPropertyGroup BaseProperties => null;
-        
-        /// <summary>
-        ///     Called when the brush is being removed from the layer
-        /// </summary>
-        public abstract void Dispose();
-
-        /// <summary>
-        ///     Called before rendering every frame, write your update logic here
-        /// </summary>
-        /// <param name="deltaTime"></param>
-        public abstract void Update(double deltaTime);
-
-        // Not only is this needed to initialize properties on the layer brushes, it also prevents implementing anything
-        // but LayerEffect<T> and RgbNetLayerEffect<T> outside the core
-        internal abstract void Initialize(ILayerService layerService);
-
-        internal abstract void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
-
-        /// <summary>
-        ///     Called when Artemis needs an instance of the RGB.NET brush you are implementing
-        /// </summary>
-        /// <returns>Your RGB.NET brush</returns>
-        internal abstract IBrush InternalGetBrush();
-    }
-}

src/Artemis.Core/Plugins/LayerEffect/LayerEffect.cs

@@ -1,95 +0,0 @@
-using System;
-using Artemis.Core.Models.Profile;
-using Artemis.Core.Plugins.Exceptions;
-using Artemis.Core.Services.Interfaces;
-using RGB.NET.Core;
-using SkiaSharp;
-
-namespace Artemis.Core.Plugins.LayerEffect
-{
-    /// <summary>
-    ///     For internal use only, please use <see cref="LayerEffect" /> instead
-    /// </summary>
-    public abstract class LayerEffect<T> : BaseLayerEffect where T : LayerPropertyGroup
-    {
-        private T _properties;
-
-        protected LayerEffect(Layer layer, LayerEffectDescriptor descriptor) : base(layer, descriptor)
-        {
-        }
-
-        /// <summary>
-        ///     Gets whether all properties on this brush are initialized
-        /// </summary>
-        public bool PropertiesInitialized { get; internal set; }
-
-        /// <inheritdoc />
-        public override LayerPropertyGroup BaseProperties => Properties;
-
-        /// <summary>
-        ///     Gets the properties of this brush.
-        /// </summary>
-        public T Properties
-        {
-            get
-            {
-                // I imagine a null reference here can be confusing, so lets throw an exception explaining what to do
-                if (_properties == null)
-                    throw new ArtemisPluginException("Cannot access brush properties until OnPropertiesInitialized has been called");
-                return _properties;
-            }
-            internal set => _properties = value;
-        }
-
-        /// <summary>
-        ///     Called when all layer properties in this brush have been initialized
-        /// </summary>
-        protected virtual void OnPropertiesInitialized()
-        {
-        }
-
-        internal void InitializeProperties(ILayerService layerService)
-        {
-            Properties = Activator.CreateInstance<T>();
-            Properties.InitializeProperties(layerService, Layer, "LayerEffect.");
-            OnPropertiesInitialized();
-            PropertiesInitialized = true;
-        }
-
-        /// <summary>
-        ///     The main method of rendering anything to the layer. The provided <see cref="SKCanvas" /> is specific to the layer
-        ///     and matches it's width and height.
-        ///     <para>Called during rendering or layer preview, in the order configured on the layer</para>
-        /// </summary>
-        /// <param name="canvas">The layer canvas</param>
-        /// <param name="canvasInfo"></param>
-        /// <param name="path">The path to be filled, represents the shape</param>
-        /// <param name="paint">The paint to be used to fill the shape</param>
-        public abstract void Render(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint);
-
-        internal override void InternalRender(SKCanvas canvas, SKImageInfo canvasInfo, SKPath path, SKPaint paint)
-        {
-            // Move the canvas to the top-left of the render path
-            canvas.Translate(path.Bounds.Left, path.Bounds.Top);
-            // Pass the render path to the layer brush positioned at 0,0
-            path.Transform(SKMatrix.MakeTranslation(path.Bounds.Left * -1, path.Bounds.Top * -1));
-
-            Render(canvas, canvasInfo, path, paint);
-        }
-
-        internal override void Initialize(ILayerService layerService)
-        {
-            InitializeProperties(layerService);
-        }
-
-        protected virtual void Dispose(bool disposing)
-        {
-        }
-
-        public sealed override void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-    }
-}

src/Artemis.Core/Plugins/Models/PluginInfo.cs

@@ -32,7 +32,8 @@ namespace Artemis.Core.Plugins.Models
         public string Description { get; set; }
 
         /// <summary>
-        ///     The plugins display icon that's shown in the settings see <see href="https://materialdesignicons.com" /> for available
+        ///     The plugins display icon that's shown in the settings see <see href="https://materialdesignicons.com" /> for
+        ///     available
         ///     icons
         /// </summary>
         public string Icon { get; set; }
@@ -84,7 +85,7 @@ namespace Artemis.Core.Plugins.Models
         /// </summary>
         [JsonIgnore]
         internal PluginEntity PluginEntity { get; set; }
-        
+
         public override string ToString()
         {
             return $"{nameof(Guid)}: {Guid}, {nameof(Name)}: {Name}, {nameof(Version)}: {Version}";

src/Artemis.Core/Plugins/Models/PluginSetting.cs

@@ -1,5 +1,4 @@
 using System;
-using Artemis.Storage.Entities;
 using Artemis.Storage.Entities.Plugins;
 using Artemis.Storage.Repositories.Interfaces;
 using Newtonsoft.Json;
@@ -10,8 +9,8 @@ namespace Artemis.Core.Plugins.Models
     {
         // ReSharper disable once NotAccessedField.Local
         private readonly PluginInfo _pluginInfo;
-        private readonly PluginSettingEntity _pluginSettingEntity;
         private readonly IPluginRepository _pluginRepository;
+        private readonly PluginSettingEntity _pluginSettingEntity;
         private T _value;
 
         internal PluginSetting(PluginInfo pluginInfo, IPluginRepository pluginRepository, PluginSettingEntity pluginSettingEntity)

src/Artemis.Core/Plugins/Models/PluginSettings.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using Artemis.Storage.Entities;
 using Artemis.Storage.Entities.Plugins;
 using Artemis.Storage.Repositories.Interfaces;
 using Newtonsoft.Json;