UI - My poor UI :< I regret starting this refactor

src/Artemis.Core/Models/Profile/LayerProperties/BaseLayerProperty.cs

@@ -9,12 +9,9 @@ namespace Artemis.Core.Models.Profile.LayerProperties
     /// </summary>
     public abstract class BaseLayerProperty
     {
-        /// <summary>
-        ///     Used to declare that this property doesn't belong to a plugin and should use the core plugin GUID
-        /// </summary>
-        internal bool IsCoreProperty { get; set; }
-        internal PropertyEntity PropertyEntity { get; set; }
-        internal LayerPropertyGroup LayerPropertyGroup { get; set; }
+        internal BaseLayerProperty()
+        {
+        }
 
         /// <summary>
         ///     Gets whether keyframes are supported on this property
@@ -42,6 +39,15 @@ namespace Artemis.Core.Models.Profile.LayerProperties
         /// </summary>
         public TimeSpan TimelineProgress { get; internal set; }
 
+        /// <summary>
+        ///     Used to declare that this property doesn't belong to a plugin and should use the core plugin GUID
+        /// </summary>
+        internal bool IsCoreProperty { get; set; }
+
+        internal PropertyEntity PropertyEntity { get; set; }
+        internal LayerPropertyGroup LayerPropertyGroup { get; set; }
+        internal abstract IReadOnlyList<BaseLayerPropertyKeyframe> BaseKeyframes { get; }
+
         /// <summary>
         ///     Applies the provided property entity to the layer property by deserializing the JSON base value and keyframe values
         /// </summary>
@@ -54,8 +60,5 @@ namespace Artemis.Core.Models.Profile.LayerProperties
         ///     <see cref="ApplyToLayerProperty" />
         /// </summary>
         internal abstract void ApplyToEntity();
-
-        internal abstract List<TimeSpan> GetKeyframePositions();
-        internal abstract TimeSpan GetLastKeyframePosition();
     }
 }

src/Artemis.Core/Models/Profile/LayerProperties/BaseLayerPropertyKeyframe.cs

@@ -0,0 +1,27 @@
+using System;
+using Artemis.Core.Utilities;
+
+namespace Artemis.Core.Models.Profile.LayerProperties
+{
+    /// <summary>
+    ///     For internal use only, use <see cref="LayerPropertyKeyframe{T}" /> instead.
+    /// </summary>
+    public abstract class BaseLayerPropertyKeyframe
+    {
+        internal BaseLayerPropertyKeyframe()
+        {
+        }
+
+        /// <summary>
+        ///     The position of this keyframe in the timeline
+        /// </summary>
+        public abstract TimeSpan Position { get; set; }
+
+        /// <summary>
+        ///     The easing function applied on the value of the keyframe
+        /// </summary>
+        public abstract Easings.Functions EasingFunction { get; set; }
+
+        internal abstract BaseLayerProperty BaseLayerProperty { get; }
+    }
+}

src/Artemis.Core/Models/Profile/LayerProperties/LayerProperty.cs

@@ -12,7 +12,8 @@ namespace Artemis.Core.Models.Profile.LayerProperties
     /// <summary>
     ///     Represents a property on a layer. Properties are saved in storage and can optionally be modified from the UI.
     ///     <para>
-    ///         Note: You cannot initialize layer properties yourself. If properly placed and annotated, the Artemis core will initialize
+    ///         Note: You cannot initialize layer properties yourself. If properly placed and annotated, the Artemis core will
+    ///         initialize
     ///         these for you.
     ///     </para>
     /// </summary>
@@ -53,12 +54,12 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             get => !KeyframesEnabled || !KeyframesSupported ? BaseValue : _currentValue;
             internal set => _currentValue = value;
         }
-        
+
         /// <summary>
         ///     Gets a read-only list of all the keyframes on this layer property
         /// </summary>
         public IReadOnlyList<LayerPropertyKeyframe<T>> Keyframes => _keyframes.AsReadOnly();
-        
+
         /// <summary>
         ///     Gets the current keyframe in the timeline according to the current progress
         /// </summary>
@@ -68,7 +69,9 @@ namespace Artemis.Core.Models.Profile.LayerProperties
         ///     Gets the next keyframe in the timeline according to the current progress
         /// </summary>
         public LayerPropertyKeyframe<T> NextKeyframe { get; protected set; }
-        
+
+        internal override IReadOnlyList<BaseLayerPropertyKeyframe> BaseKeyframes => _keyframes.Cast<BaseLayerPropertyKeyframe>().ToList().AsReadOnly();
+
         /// <summary>
         ///     Adds a keyframe to the layer property
         /// </summary>
@@ -93,6 +96,16 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             OnKeyframeRemoved();
         }
 
+        /// <summary>
+        ///     Removes all keyframes from the layer property
+        /// </summary>
+        public void ClearKeyframes()
+        {
+            var keyframes = new List<LayerPropertyKeyframe<T>>(_keyframes);
+            foreach (var layerPropertyKeyframe in keyframes)
+                RemoveKeyframe(layerPropertyKeyframe);
+        }
+
         /// <summary>
         ///     Called every update (if keyframes are both supported and enabled) to determine the new <see cref="CurrentValue" />
         ///     based on the provided progress
@@ -167,6 +180,7 @@ namespace Artemis.Core.Models.Profile.LayerProperties
                 IsLoadedFromStorage = true;
                 BaseValue = JsonConvert.DeserializeObject<T>(entity.Value);
                 CurrentValue = BaseValue;
+                KeyframesEnabled = entity.KeyframesEnabled;
 
                 _keyframes.Clear();
                 _keyframes.AddRange(entity.KeyframeEntities.Select(k => new LayerPropertyKeyframe<T>(
@@ -194,6 +208,7 @@ namespace Artemis.Core.Models.Profile.LayerProperties
                 throw new ArtemisCoreException("Layer property is not yet initialized");
 
             PropertyEntity.Value = JsonConvert.SerializeObject(BaseValue);
+            PropertyEntity.KeyframesEnabled = KeyframesEnabled;
             PropertyEntity.KeyframeEntities.Clear();
             PropertyEntity.KeyframeEntities.AddRange(Keyframes.Select(k => new KeyframeEntity
             {
@@ -203,16 +218,6 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             }));
         }
 
-        internal override List<TimeSpan> GetKeyframePositions()
-        {
-            return Keyframes.Select(k => k.Position).ToList();
-        }
-
-        internal override TimeSpan GetLastKeyframePosition()
-        {
-            return Keyframes.LastOrDefault()?.Position ?? TimeSpan.Zero;
-        }
-
         #region Events
 
         public event EventHandler Updated;

src/Artemis.Core/Models/Profile/LayerProperties/LayerPropertyKeyFrame.cs

@@ -3,7 +3,7 @@ using Artemis.Core.Utilities;
 
 namespace Artemis.Core.Models.Profile.LayerProperties
 {
-    public class LayerPropertyKeyframe<T>
+    public class LayerPropertyKeyframe<T> : BaseLayerPropertyKeyframe
     {
         private TimeSpan _position;
 
@@ -14,10 +14,18 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             EasingFunction = easingFunction;
         }
 
+        /// <summary>
+        ///     The layer property this keyframe is applied to
+        /// </summary>
         public LayerProperty<T> LayerProperty { get; internal set; }
+
+        /// <summary>
+        ///     The value of this keyframe
+        /// </summary>
         public T Value { get; set; }
 
-        public TimeSpan Position
+        /// <inheritdoc />
+        public override TimeSpan Position
         {
             get => _position;
             set
@@ -27,6 +35,9 @@ namespace Artemis.Core.Models.Profile.LayerProperties
             }
         }
 
-        public Easings.Functions EasingFunction { get; set; }
+        /// <inheritdoc />
+        public sealed override Easings.Functions EasingFunction { get; set; }
+
+        internal override BaseLayerProperty BaseLayerProperty => LayerProperty;
     }
 }