Core - Fixed data model namespaces

Modules - Added IsPropertyInUse API
UI - Properly dispose data model paths wherever they are used

src/Artemis.Core/Models/Profile/Conditions/Wrappers/EventPredicateWrapperDataModel.cs

@@ -1,5 +1,5 @@
 using System;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/Conditions/Wrappers/ListPredicateWrapperDataModel.cs

@@ -1,5 +1,5 @@
 using System;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/DataBindings/IDataBinding.cs

@@ -1,5 +1,5 @@
 using System;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/DataModel/DataModelEvent.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/DataModel/DataModelEventArgs.cs

@@ -1,5 +1,5 @@
 using System;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/DataModel/DataModelPath.cs

@@ -3,7 +3,7 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 using Artemis.Storage.Entities.Profile;
 
 namespace Artemis.Core
@@ -175,6 +175,8 @@ namespace Artemis.Core
 
         internal void Invalidate()
         {
+            Target?.RemoveDataModelPath(this);
+
             foreach (DataModelPathSegment dataModelPathSegment in _segments)
                 dataModelPathSegment.Dispose();
             _segments.Clear();
@@ -187,11 +189,11 @@ namespace Artemis.Core
 
         internal void Initialize()
         {
-            Invalidate();
-
             if (Target == null)
                 return;
 
+            Target.AddDataModelPath(this);
+
             DataModelPathSegment startSegment = new(this, "target", "target");
             startSegment.Node = _segments.AddFirst(startSegment);
 
@@ -260,7 +262,7 @@ namespace Artemis.Core
             DataModelStore.DataModelAdded += DataModelStoreOnDataModelAdded;
             DataModelStore.DataModelRemoved += DataModelStoreOnDataModelRemoved;
         }
-
+        
         #region IDisposable
 
         /// <summary>
@@ -330,6 +332,7 @@ namespace Artemis.Core
             if (e.Registration.DataModel.Module.Id != Entity.DataModelId)
                 return;
 
+            Invalidate();
             Target = e.Registration.DataModel;
             Initialize();
         }
@@ -339,8 +342,8 @@ namespace Artemis.Core
             if (e.Registration.DataModel.Module.Id != Entity.DataModelId)
                 return;
 
-            Target = null;
             Invalidate();
+            Target = null;
         }
 
         #endregion

src/Artemis.Core/Models/Profile/DataModel/DataModelPathSegment.cs

@@ -3,7 +3,7 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 using Humanizer;
 
 namespace Artemis.Core
@@ -301,7 +301,7 @@ namespace Artemis.Core
         private void DynamicChildOnDynamicChildRemoved(object? sender, DynamicDataModelChildEventArgs e)
         {
             if (e.DynamicChild.BaseValue == _dynamicDataModel)
-                DataModelPath.Initialize();
+                DataModelPath.Invalidate();
         }
 
         #endregion

src/Artemis.Core/Models/Profile/DataModel/ValueChangedEvent/DataModelValueChangedEventArgs.cs

@@ -1,4 +1,4 @@
-using Artemis.Core.DataModelExpansions;
+using Artemis.Core.Modules;
 
 namespace Artemis.Core
 {

src/Artemis.Core/Models/Profile/ProfileCategory.cs

@@ -5,6 +5,9 @@ using Artemis.Storage.Entities.Profile;
 
 namespace Artemis.Core
 {
+    /// <summary>
+    ///     Represents a category containing <see cref="ProfileConfigurations" />
+    /// </summary>
     public class ProfileCategory : CorePropertyChanged, IStorageModel
     {
         private readonly List<ProfileConfiguration> _profileConfigurations = new();

src/Artemis.Core/Models/Profile/RenderProfileElement.cs

@@ -59,6 +59,8 @@ namespace Artemis.Core
             foreach (BaseLayerEffect baseLayerEffect in LayerEffects)
                 baseLayerEffect.Dispose();
 
+            DisplayCondition?.Dispose();
+
             base.Dispose(disposing);
         }
 

src/Artemis.Core/Models/ProfileConfiguration/ProfileConfiguration.cs

@@ -1,13 +1,18 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Artemis.Core.Modules;
 using Artemis.Storage.Entities.Profile;
 
 namespace Artemis.Core
 {
-    public class ProfileConfiguration : CorePropertyChanged, IStorageModel
+    /// <summary>
+    ///     Represents the configuration of a profile, contained in a <see cref="ProfileCategory" />
+    /// </summary>
+    public class ProfileConfiguration : CorePropertyChanged, IStorageModel, IDisposable
     {
         private ProfileCategory _category;
+        private bool _disposed;
 
         private bool _isMissingModule;
         private bool _isSuspended;
@@ -140,11 +145,17 @@ namespace Artemis.Core
         /// </summary>
         public void Update()
         {
+            if (_disposed)
+                throw new ObjectDisposedException("ProfileConfiguration");
+
             ActivationConditionMet = ActivationCondition == null || ActivationCondition.Evaluate();
         }
 
         public bool ShouldBeActive(bool includeActivationCondition)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("ProfileConfiguration");
+
             if (Category.IsSuspended || IsSuspended || IsMissingModule)
                 return false;
 
@@ -161,15 +172,32 @@ namespace Artemis.Core
 
         internal void LoadModules(List<Module> enabledModules)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("ProfileConfiguration");
+
             Module = enabledModules.FirstOrDefault(m => m.Id == Entity.ModuleId);
             IsMissingModule = Module == null && Entity.ModuleId != null;
         }
 
+        #region IDisposable
+
+        /// <inheritdoc />
+        public void Dispose()
+        {
+            _disposed = true;
+            ActivationCondition?.Dispose();
+        }
+
+        #endregion
+
         #region Implementation of IStorageModel
 
         /// <inheritdoc />
         public void Load()
         {
+            if (_disposed)
+                throw new ObjectDisposedException("ProfileConfiguration");
+
             Name = Entity.Name;
             IsSuspended = Entity.IsSuspended;
             ActivationBehaviour = (ActivationBehaviour) Entity.ActivationBehaviour;
@@ -185,6 +213,9 @@ namespace Artemis.Core
         /// <inheritdoc />
         public void Save()
         {
+            if (_disposed)
+                throw new ObjectDisposedException("ProfileConfiguration");
+
             Entity.Name = Name;
             Entity.IsSuspended = IsSuspended;
             Entity.ActivationBehaviour = (int) ActivationBehaviour;
@@ -199,9 +230,7 @@ namespace Artemis.Core
                 Entity.ActivationCondition = ActivationCondition.Entity;
             }
             else
-            {
                 Entity.ActivationCondition = null;
-            }
 
             if (!IsMissingModule)
                 Entity.ModuleId = Module?.Id;