Layer properties - Improved error messaging

Profile editor - Fixed layer creation in selection tool not initializing the layer
Device visualizer - Better handle missing images

src/Artemis.Core/Artemis.Core.csproj

@@ -14,6 +14,9 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
     <DebugType>pdbonly</DebugType>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <PlatformTarget>x64</PlatformTarget>
+  </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\Artemis.Storage\Artemis.Storage.csproj">
       <Private>false</Private>

src/Artemis.Core/Models/Profile/Folder.cs

@@ -72,14 +72,6 @@ namespace Artemis.Core.Models.Profile
             return folder;
         }
 
-        public Layer AddLayer(string name)
-        {
-            var layer = new Layer(Profile, this, name) {Order = Children.LastOrDefault()?.Order ?? 1};
-            layer.LayerShape = new Rectangle(layer);
-            AddChild(layer);
-            return layer;
-        }
-
         public override string ToString()
         {
             return $"[Folder] {nameof(Name)}: {Name}, {nameof(Order)}: {Order}";

src/Artemis.Core/Models/Profile/LayerPropertyGroup.cs

@@ -130,14 +130,17 @@ namespace Artemis.Core.Models.Profile
                 if (propertyDescription != null)
                 {
                     if (!typeof(BaseLayerProperty).IsAssignableFrom(propertyInfo.PropertyType))
-                        throw new ArtemisPluginException("Layer property with PropertyDescription attribute must be of type LayerProperty");
+                        throw new ArtemisPluginException($"Layer property with PropertyDescription attribute must be of type LayerProperty at {path + propertyInfo.Name}");
 
                     var instance = (BaseLayerProperty) Activator.CreateInstance(propertyInfo.PropertyType, true);
-                    instance.Parent = this;
-                    instance.PropertyDescription = (PropertyDescriptionAttribute)propertyDescription;
+                    if (instance == null)
+                        throw new ArtemisPluginException($"Failed to create instance of layer property at {path + propertyInfo.Name}");
+
                     instance.Layer = layer;
-                    
+                    instance.Parent = this;
+                    instance.PropertyDescription = (PropertyDescriptionAttribute) propertyDescription;
                     InitializeProperty(layer, path + propertyInfo.Name, instance);
+
                     propertyInfo.SetValue(this, instance);
                     _layerProperties.Add(instance);
                 }
@@ -150,16 +153,23 @@ namespace Artemis.Core.Models.Profile
                             throw new ArtemisPluginException("Layer property with PropertyGroupDescription attribute must be of type LayerPropertyGroup");
 
                         var instance = (LayerPropertyGroup) Activator.CreateInstance(propertyInfo.PropertyType);
+                        if (instance == null)
+                            throw new ArtemisPluginException($"Failed to create instance of layer property group at {path + propertyInfo.Name}");
+
                         instance.Parent = this;
-                        instance.GroupDescription = (PropertyGroupDescriptionAttribute)propertyGroupDescription;
+                        instance.GroupDescription = (PropertyGroupDescriptionAttribute) propertyGroupDescription;
                         instance.InitializeProperties(layerService, layer, $"{path}{propertyInfo.Name}.");
+
                         propertyInfo.SetValue(this, instance);
                         _layerPropertyGroups.Add(instance);
                     }
                 }
             }
 
+            // Request the property group to populate defaults
             PopulateDefaults();
+
+            // Apply the newly populated defaults
             foreach (var layerProperty in _layerProperties.Where(p => !p.IsLoadedFromStorage))
                 layerProperty.ApplyDefaultValue();
 
@@ -167,7 +177,7 @@ namespace Artemis.Core.Models.Profile
             PropertiesInitialized = true;
             OnPropertyGroupInitialized();
         }
-        
+
         internal void ApplyToEntity()
         {
             if (!PropertiesInitialized)

src/Artemis.Core/Services/LayerService.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Linq;
+using Artemis.Core.Exceptions;
 using Artemis.Core.Models.Profile;
 using Artemis.Core.Plugins.LayerBrush;
 using Artemis.Core.Services.Interfaces;
@@ -25,6 +26,7 @@ namespace Artemis.Core.Services
         public Layer CreateLayer(Profile profile, ProfileElement parent, string name)
         {
             var layer = new Layer(profile, parent, name);
+            parent.AddChild(layer);
 
             // Layers have two hardcoded property groups, instantiate them
             layer.General.InitializeProperties(this, layer, "General.");
@@ -60,6 +62,7 @@ namespace Artemis.Core.Services
             };
             layer.LayerBrush = (BaseLayerBrush) _kernel.Get(descriptor.LayerBrushType, arguments);
             layer.LayerBrush.Initialize(this);
+            layer.LayerBrush.Update(0);
             layer.OnLayerBrushUpdated();
             return layer.LayerBrush;
         }