From 13d7081c725e54d6457c2540d8551ac2502ea8fa Mon Sep 17 00:00:00 2001
From: Robert <mail@rbeekman.nl>
Date: Sat, 8 May 2021 22:02:44 +0200
Subject: [PATCH] Prerequisite install - Interrupt installation if not met

---
 .../PluginPrerequisitesInstallDialogView.xaml | 35 ++++++---
 ...uginPrerequisitesInstallDialogViewModel.cs | 72 +++++++++++--------
 2 files changed, 66 insertions(+), 41 deletions(-)

diff --git a/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogView.xaml b/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogView.xaml
index d4c933acc..1fbb9e213 100644
--- a/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogView.xaml
+++ b/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogView.xaml
@@ -7,17 +7,20 @@
              xmlns:s="https://github.com/canton7/Stylet"
              xmlns:shared="clr-namespace:Artemis.UI.Shared;assembly=Artemis.UI.Shared"
              xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
+             xmlns:converters="clr-namespace:Artemis.UI.Converters"
              mc:Ignorable="d"
              d:DesignHeight="450" d:DesignWidth="800"
              d:DataContext="{d:DesignInstance local:PluginPrerequisitesInstallDialogViewModel}">
     <UserControl.Resources>
-        <shared:NullToVisibilityConverter x:Key="NullToVisibilityConverter"/>
+        <converters:InverseBooleanConverter x:Key="InverseBooleanConverter"/>
+        <converters:NullToBooleanConverter x:Key="NullToBooleanConverter" />
+        <shared:NullToVisibilityConverter x:Key="NullToVisibilityConverter" />
     </UserControl.Resources>
     <Grid Margin="16">
         <Grid.RowDefinitions>
             <RowDefinition Height="Auto" />
-            <RowDefinition MinHeight="150"/>
-            <RowDefinition Height="Auto"/>
+            <RowDefinition MinHeight="150" />
+            <RowDefinition Height="Auto" />
         </Grid.RowDefinitions>
         <Grid.ColumnDefinitions>
             <ColumnDefinition Width="300" />
@@ -32,7 +35,6 @@
                  ItemsSource="{Binding Prerequisites}"
                  SelectedItem="{Binding ActivePrerequisite, Mode=OneWay}"
                  HorizontalContentAlignment="Stretch">
-
             <ListBox.ItemTemplate>
                 <DataTemplate DataType="{x:Type local:PluginPrerequisiteViewModel}">
                     <Border Padding="8" BorderThickness="0 0 0 1" BorderBrush="{DynamicResource MaterialDesignDivider}" VerticalAlignment="Stretch">
@@ -75,26 +77,36 @@
                         HorizontalContentAlignment="Stretch"
                         Margin="10 0"
                         IsTabStop="False"
-                        Visibility="{Binding ActivePrerequisite, Converter={StaticResource NullToVisibilityConverter}}"/>
+                        Visibility="{Binding ShowProgress, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}" />
 
-        <TextBlock Grid.Row="1" 
-                   Grid.Column="1" 
-                   Style="{StaticResource MaterialDesignBody1TextBlock}" 
+        <TextBlock Grid.Row="1"
+                   Grid.Column="1"
+                   Style="{StaticResource MaterialDesignBody1TextBlock}"
                    TextWrapping="Wrap"
                    Margin="10 0"
-                   Visibility="{Binding ActivePrerequisite, Converter={StaticResource NullToVisibilityConverter}, ConverterParameter=Inverted}">
+                   Visibility="{Binding ShowIntro, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}">
             In order for this plugin/feature to function certain prerequisites must be met. <LineBreak /><LineBreak />
             On the left side you can see all prerequisites and whether they are currently met or not.
             Clicking install prerequisites will automatically set everything up for you.
         </TextBlock>
 
+        <TextBlock Grid.Row="1"
+                   Grid.Column="1"
+                   Style="{StaticResource MaterialDesignBody1TextBlock}"
+                   TextWrapping="Wrap"
+                   Margin="10 0"
+                   Visibility="{Binding ShowFailed, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}">
+            Installing <Run Text="{Binding ActivePrerequisite.PluginPrerequisite.Name, Mode=OneWay}" FontWeight="SemiBold" /> failed. <LineBreak /><LineBreak />
+            You may try again to see if that helps, otherwise install the prerequisite manually or contact the plugin developer.
+        </TextBlock>
+
         <StackPanel Grid.Row="2"
                     Grid.Column="0"
                     Grid.ColumnSpan="2"
                     Orientation="Horizontal"
                     HorizontalAlignment="Right"
                     Margin="0 8 0 0"
-                    Visibility="{Binding IsFinished, Converter={x:Static s:BoolToVisibilityConverter.InverseInstance}, Mode=OneWay}">
+                    Visibility="{Binding ShowInstall, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}">
             <Button Style="{StaticResource MaterialDesignFlatButton}"
                     Focusable="False"
                     IsCancel="True"
@@ -104,6 +116,7 @@
                     Style="{StaticResource MaterialDesignFlatButton}"
                     IsDefault="True"
                     Focusable="True"
+                    IsEnabled="{Binding ShowProgress, Converter={StaticResource InverseBooleanConverter}, Mode=OneWay}"
                     Command="{s:Action Install}"
                     Content="INSTALL PREREQUISITES" />
         </StackPanel>
@@ -114,7 +127,7 @@
                     Orientation="Horizontal"
                     HorizontalAlignment="Right"
                     Margin="0 8 0 0"
-                    Visibility="{Binding IsFinished, Converter={x:Static s:BoolToVisibilityConverter.Instance}, Mode=OneWay}">
+                    Visibility="{Binding ShowInstall, Converter={x:Static s:BoolToVisibilityConverter.InverseInstance}, Mode=OneWay}">
             <Button Style="{StaticResource MaterialDesignFlatButton}"
                     Focusable="False"
                     IsCancel="True"
diff --git a/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogViewModel.cs b/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogViewModel.cs
index 6b95d93c5..594b5d5ab 100644
--- a/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogViewModel.cs
+++ b/src/Artemis.UI/Screens/Plugins/PluginPrerequisitesInstallDialogViewModel.cs
@@ -13,18 +13,16 @@ namespace Artemis.UI.Screens.Plugins
 {
     public class PluginPrerequisitesInstallDialogViewModel : DialogViewModelBase
     {
-        private readonly IDialogService _dialogService;
-        private readonly List<IPrerequisitesSubject> _subjects;
         private PluginPrerequisiteViewModel _activePrerequisite;
-        private bool _canInstall;
-        private bool _isFinished;
         private CancellationTokenSource _tokenSource;
+        private bool _showProgress;
+        private bool _showIntro = true;
+        private bool _showFailed;
+        private bool _showInstall = true;
+        private bool _canInstall;
 
         public PluginPrerequisitesInstallDialogViewModel(List<IPrerequisitesSubject> subjects, IPrerequisitesVmFactory prerequisitesVmFactory, IDialogService dialogService)
         {
-            _subjects = subjects;
-            _dialogService = dialogService;
-
             Prerequisites = new BindableCollection<PluginPrerequisiteViewModel>();
             foreach (IPrerequisitesSubject prerequisitesSubject in subjects)
                 Prerequisites.AddRange(prerequisitesSubject.Prerequisites.Select(p => prerequisitesVmFactory.PluginPrerequisiteViewModel(p, false)));
@@ -41,18 +39,36 @@ namespace Artemis.UI.Screens.Plugins
             set => SetAndNotify(ref _activePrerequisite, value);
         }
 
+        public bool ShowProgress
+        {
+            get => _showProgress;
+            set => SetAndNotify(ref _showProgress, value);
+        }
+
+        public bool ShowIntro
+        {
+            get => _showIntro;
+            set => SetAndNotify(ref _showIntro, value);
+        }
+
+        public bool ShowFailed
+        {
+            get => _showFailed;
+            set => SetAndNotify(ref _showFailed, value);
+        }
+
+        public bool ShowInstall
+        {
+            get => _showInstall;
+            set => SetAndNotify(ref _showInstall, value);
+        }
+
         public bool CanInstall
         {
             get => _canInstall;
             set => SetAndNotify(ref _canInstall, value);
         }
 
-        public bool IsFinished
-        {
-            get => _isFinished;
-            set => SetAndNotify(ref _isFinished, value);
-        }
-
         #region Overrides of DialogViewModelBase
 
         /// <inheritdoc />
@@ -67,6 +83,10 @@ namespace Artemis.UI.Screens.Plugins
         public async void Install()
         {
             CanInstall = false;
+            ShowFailed = false;
+            ShowIntro = false;
+            ShowProgress = true;
+
             _tokenSource = new CancellationTokenSource();
 
             try
@@ -80,27 +100,20 @@ namespace Artemis.UI.Screens.Plugins
                     ActivePrerequisite = pluginPrerequisiteViewModel;
                     await ActivePrerequisite.Install(_tokenSource.Token);
 
+                    if (!ActivePrerequisite.IsMet)
+                    {
+                        CanInstall = true;
+                        ShowFailed = true;
+                        ShowProgress = false;
+                        return;
+                    }
+
                     // Wait after the task finished for the user to process what happened
                     if (pluginPrerequisiteViewModel != Prerequisites.Last())
                         await Task.Delay(1000);
                 }
 
-                if (Prerequisites.All(p => p.IsMet))
-                {
-                    IsFinished = true;
-                    return;
-                }
-
-                // This shouldn't be happening and the experience isn't very nice for the user (too lazy to make a nice UI for such an edge case)
-                // but at least give some feedback
-                Session?.Close(false);
-                await _dialogService.ShowConfirmDialog(
-                    "Plugin prerequisites",
-                    "All prerequisites are installed but some still aren't met. \r\nPlease try again or contact the plugin creator.",
-                    "Confirm",
-                    ""
-                );
-                await Show(_dialogService, _subjects);
+                ShowInstall = false;
             }
             catch (OperationCanceledException)
             {
@@ -108,7 +121,6 @@ namespace Artemis.UI.Screens.Plugins
             }
             finally
             {
-                CanInstall = true;
                 _tokenSource.Dispose();
                 _tokenSource = null;
             }