Display conditions - Implemented IDisposable

Display conditions - Listen to registration add/remove WIP
Data bindings - Implemented IDisposable
Data bindings - Listen to registration add/remove

src/Artemis.Core/Models/Profile/DataBindings/DataBindingModifier.cs

@@ -2,7 +2,6 @@
 using System.Linq;
 using System.Linq.Expressions;
 using Artemis.Core.DataModelExpansions;
-using Artemis.Core.Services;
 using Artemis.Storage.Entities.Profile.DataBindings;
 using Newtonsoft.Json;
 
@@ -12,6 +11,7 @@ namespace Artemis.Core
     public class DataBindingModifier<TLayerProperty, TProperty> : IDataBindingModifier
     {
         private DataBinding<TLayerProperty, TProperty> _dataBinding;
+        private bool _disposed;
 
         /// <summary>
         ///     Creates a new instance of the <see cref="DataBindingModifier{TLayerProperty,TProperty}" /> class
@@ -22,6 +22,7 @@ namespace Artemis.Core
             ParameterType = parameterType;
             Entity = new DataBindingModifierEntity();
             Save();
+            Initialize();
         }
 
         internal DataBindingModifier(DataBinding<TLayerProperty, TProperty> dataBinding, DataBindingModifierEntity entity)
@@ -29,6 +30,7 @@ namespace Artemis.Core
             DataBinding = dataBinding;
             Entity = entity;
             Load();
+            Initialize();
         }
 
         /// <summary>
@@ -82,6 +84,52 @@ namespace Artemis.Core
 
         internal DataBindingModifierEntity Entity { get; set; }
 
+
+        /// <inheritdoc />
+        public void Save()
+        {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
+            if (!DataBinding.Entity.Modifiers.Contains(Entity))
+                DataBinding.Entity.Modifiers.Add(Entity);
+
+            // Modifier
+            if (ModifierType != null)
+            {
+                Entity.ModifierType = ModifierType.GetType().Name;
+                Entity.ModifierTypePluginGuid = ModifierType.PluginInfo.Guid;
+            }
+
+            // General
+            Entity.Order = Order;
+            Entity.ParameterType = (int) ParameterType;
+
+            // Parameter
+            if (ParameterDataModel != null)
+            {
+                Entity.ParameterDataModelGuid = ParameterDataModel.PluginInfo.Guid;
+                Entity.ParameterPropertyPath = ParameterPropertyPath;
+            }
+
+            Entity.ParameterStaticValue = JsonConvert.SerializeObject(ParameterStaticValue);
+        }
+
+        /// <inheritdoc />
+        public void Load()
+        {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
+            // Modifier type is done during Initialize
+
+            // General
+            Order = Entity.Order;
+            ParameterType = (ProfileRightSideType) Entity.ParameterType;
+
+            // Parameter is done during initialize
+        }
+
         /// <summary>
         ///     Applies the modifier to the provided value
         /// </summary>
@@ -89,6 +137,9 @@ namespace Artemis.Core
         /// <returns>The modified value</returns>
         public object Apply(object currentValue)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
             if (ModifierType == null)
                 return currentValue;
 
@@ -113,6 +164,9 @@ namespace Artemis.Core
         /// <param name="modifierType"></param>
         public void UpdateModifierType(DataBindingModifierType modifierType)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
             // Calling CreateExpression will clear compiled expressions
             if (modifierType == null)
             {
@@ -139,6 +193,9 @@ namespace Artemis.Core
         /// <param name="path">The path pointing to the parameter inside the data model</param>
         public void UpdateParameter(DataModel dataModel, string path)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
             if (dataModel != null && path == null)
                 throw new ArtemisCoreException("If a data model is provided, a path is also required");
             if (dataModel == null && path != null)
@@ -163,6 +220,9 @@ namespace Artemis.Core
         /// <param name="staticValue">The static value to use as a parameter</param>
         public void UpdateParameter(object staticValue)
         {
+            if (_disposed)
+                throw new ObjectDisposedException("DataBindingModifier");
+
             ParameterType = ProfileRightSideType.Static;
             ParameterDataModel = null;
             ParameterPropertyPath = null;
@@ -183,12 +243,17 @@ namespace Artemis.Core
             CreateExpression();
         }
 
-        internal void Initialize(IDataModelService dataModelService, IDataBindingService dataBindingService)
+        private void Initialize()
         {
+            DataBindingModifierTypeStore.DataBindingModifierAdded += DataBindingModifierTypeStoreOnDataBindingModifierAdded;
+            DataBindingModifierTypeStore.DataBindingModifierRemoved += DataBindingModifierTypeStoreOnDataBindingModifierRemoved;
+            DataModelStore.DataModelAdded += DataModelStoreOnDataModelAdded;
+            DataModelStore.DataModelRemoved += DataModelStoreOnDataModelRemoved;
+
             // Modifier type
             if (Entity.ModifierTypePluginGuid != null && ModifierType == null)
             {
-                var modifierType = dataBindingService.GetModifierType(Entity.ModifierTypePluginGuid.Value, Entity.ModifierType);
+                var modifierType = DataBindingModifierTypeStore.Get(Entity.ModifierTypePluginGuid.Value, Entity.ModifierType)?.DataBindingModifierType;
                 if (modifierType != null)
                     UpdateModifierType(modifierType);
             }
@@ -196,7 +261,7 @@ namespace Artemis.Core
             // Dynamic parameter
             if (ParameterType == ProfileRightSideType.Dynamic && Entity.ParameterDataModelGuid != null && ParameterDataModel == null)
             {
-                var dataModel = dataModelService.GetPluginDataModelByGuid(Entity.ParameterDataModelGuid.Value);
+                var dataModel = DataModelStore.Get(Entity.ParameterDataModelGuid.Value)?.DataModel;
                 if (dataModel != null && dataModel.ContainsPath(Entity.ParameterPropertyPath))
                     UpdateParameter(dataModel, Entity.ParameterPropertyPath);
             }
@@ -214,7 +279,7 @@ namespace Artemis.Core
                 // If deserialization fails, use the type's default
                 catch (JsonSerializationException e)
                 {
-                    dataBindingService.LogModifierDeserializationFailure(GetType().Name, e);
+                    DeserializationLogger.LogModifierDeserializationFailure(GetType().Name, e);
                     staticValue = Activator.CreateInstance(targetType);
                 }
 
@@ -222,39 +287,6 @@ namespace Artemis.Core
             }
         }
 
-        /// <inheritdoc />
-        public void Save()
-        {
-            if (!DataBinding.Entity.Modifiers.Contains(Entity))
-                DataBinding.Entity.Modifiers.Add(Entity);
-
-            // Modifier
-            Entity.ModifierType = ModifierType?.GetType().Name;
-            Entity.ModifierTypePluginGuid = ModifierType?.PluginInfo.Guid;
-
-            // General
-            Entity.Order = Order;
-            Entity.ParameterType = (int) ParameterType;
-
-            // Parameter
-            Entity.ParameterDataModelGuid = ParameterDataModel?.PluginInfo.Guid;
-            Entity.ParameterPropertyPath = ParameterPropertyPath;
-            Entity.ParameterStaticValue = JsonConvert.SerializeObject(ParameterStaticValue);
-        }
-
-        /// <inheritdoc />
-        public void Load()
-        {
-            // Modifier type is done during Initialize
-
-            // General
-            Order = Entity.Order;
-            ParameterType = (ProfileRightSideType) Entity.ParameterType;
-
-            // Parameter is done during initialize
-        }
-
-
         private void CreateExpression()
         {
             CompiledParameterAccessor = null;
@@ -286,5 +318,51 @@ namespace Artemis.Core
                 Expression.Property
             );
         }
+
+        #region Event handlers
+
+        private void DataBindingModifierTypeStoreOnDataBindingModifierAdded(object sender, DataBindingModifierTypeStoreEvent e)
+        {
+            if (ModifierType != null)
+                return;
+
+            var modifierType = e.TypeRegistration.DataBindingModifierType;
+            if (modifierType.PluginInfo.Guid == Entity.ModifierTypePluginGuid && modifierType.GetType().Name == Entity.ModifierType)
+                UpdateModifierType(modifierType);
+        }
+
+        private void DataBindingModifierTypeStoreOnDataBindingModifierRemoved(object sender, DataBindingModifierTypeStoreEvent e)
+        {
+            if (e.TypeRegistration.DataBindingModifierType == ModifierType)
+                UpdateModifierType(null);
+        }
+
+        private void DataModelStoreOnDataModelAdded(object sender, DataModelStoreEvent e)
+        {
+            var dataModel = e.Registration.DataModel;
+            if (dataModel.PluginInfo.Guid == Entity.ParameterDataModelGuid && dataModel.ContainsPath(Entity.ParameterPropertyPath))
+                UpdateParameter(dataModel, Entity.ParameterPropertyPath);
+        }
+
+        private void DataModelStoreOnDataModelRemoved(object sender, DataModelStoreEvent e)
+        {
+            if (e.Registration.DataModel != ParameterDataModel) 
+                return;
+            ParameterDataModel = null;
+            CompiledParameterAccessor = null;
+        }
+
+        #endregion
+
+        /// <inheritdoc />
+        public void Dispose()
+        {
+            _disposed = true;
+
+            DataBindingModifierTypeStore.DataBindingModifierAdded -= DataBindingModifierTypeStoreOnDataBindingModifierAdded;
+            DataBindingModifierTypeStore.DataBindingModifierRemoved -= DataBindingModifierTypeStoreOnDataBindingModifierRemoved;
+            DataModelStore.DataModelAdded -= DataModelStoreOnDataModelAdded;
+            DataModelStore.DataModelRemoved -= DataModelStoreOnDataModelRemoved;
+        }
     }
 }